New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIALS behaviour with incomplete Eiger data sets #605
Comments
Suggestion from @dagewa is to use image_range= as a workaround - reasonable, will see if this works. |
Error is
if try to import master with missing block |
image_range= does not work around this problem... |
Also turns out to dig a lot of holes - the resulting data structures are pretty universally inconsistent. Almost certainly better idea is to be able to rewrite the master file $somehow with no references to the missing files... |
I think this issue should be addressed not only by DIALS but also by EIGER detector software. How about bringing this to the HDRMX mailing list? |
@biochem-fan exactly what I am doing literally at this instant 🙂 |
Even with rewriting the master file, the feature with data range is still appreciated in some occasions. E.x. with SSX file, a dataset is often quite large, over 100K images. It takes a looooong time to load the whole dataset though one may just want to analyze a small fraction of images. |
As Aaron and David requested, I uploaded an example dataset, https://drive.google.com/open?id=1QALbjV7KYquhuMlGOeU1Akswlhxhf0F5. The experiment was set to collect 1M images for jet SSX, and aborted after some time. test-lyso_1_master.h5 and test-lyso_1_data_000001.h5 are the original images, which doesn't work with dials.import. test-lyso_1_master_new.h5 is the new master file, removing the datalinks by h5py, and dials.import works then. |
I confirm that this remains a problem using @JieNanMAXIV's example dataset |
This issue has been automatically marked as stale because it has not had recent activity. The label will be removed automatically if any activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. The label will be removed automatically if any activity occurs. Thank you for your contributions. |
Please reopen if this is found to still be an occuring issue on recent data collections |
If a data collection is aborted with an Eiger the master file will contain references to data files which will never exist i.e. if a 3600 image data set is planned but aborted some way through the master file becomes "broken"
What should the correct behaviour be?
The text was updated successfully, but these errors were encountered: