Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unicode output in HTML report #983

Merged
merged 6 commits into from
Nov 5, 2019
Merged

Allow unicode output in HTML report #983

merged 6 commits into from
Nov 5, 2019

Conversation

benjaminhwilliams
Copy link
Member

This time, I think it works...

Not intended for merge until after DIALS 2.0 release.

@benjaminhwilliams benjaminhwilliams mentioned this pull request Oct 23, 2019
Merged
@benjaminhwilliams
Copy link
Member Author

Better articulated:
At present, if you put a unicode character in any logging call, the HTML report generation falls over with a UnicodeEncodeError (or maybe it was a UnicodeDecodeError, I've forgotten). This fixes that, so now you can write all the unicode you want.

Μπορῶ νὰ φάω σπασμένα γυαλιὰ χωρὶς νὰ πάθω τίποτα.

@benjaminhwilliams
Merge branch 'master' into unicode
60102bb
@benjaminhwilliams
Fix Python 3 TypeError
72f1f92 
Fixes "TypeError: write() argument must be str, not bytes"
@benjaminhwilliams
Copy link
Member Author

@Anthchirp, the only test failure here is dials.test.test_scitbx.test_complex_double_none_comparison on the Python 3.6 build. I'm guessing this has nothing to do with the PR...

@benjaminhwilliams
Add newsfragment
9259ae3
@benjaminhwilliams
Amend newsfragment
3083e1a 
I wasn't sure how to describe this misc newsfragment, given that it's
not likely to be an interesting release note from the point of view of
most users.  Hopefully this is slightly better.
Anthchirp
Anthchirp approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds plausible.

@Anthchirp
Copy link
Member

failing test is something else, @ndevenish is looking into that.

@benjaminhwilliams benjaminhwilliams merged commit 7aa887b into master Nov 5, 2019
@benjaminhwilliams benjaminhwilliams deleted the unicode branch November 5, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthchirp Anthchirp Anthchirp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benjaminhwilliams @Anthchirp