Update isort to 5.4.2 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repository does not accept pull requests, please resubmit pull request to cctbx/dxtbx |
|
Okay, I admit I made this mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isort had a big release (or set of releases), which makes it's classification of dependencies a lot more deterministic and reliable in the face of changing environments (PyCQA/isort#1147), as well as adding adds a load of controls for when it works.
This updates it, the main side-effect of is that
psanaandpycbfare now treated as third-party; this probably makes sense as a classification for import sorting. It also separates dials, which I've added in as an extra, manual section - it makes sense to keep this close to dxtbx where used, although we should probably try to remove these few recursive dependencies where they aren't protected.