Installation Tests fail (win)

[zhiyue]

environment:

• windows 10.0.19044 Build 19044

Installation Tests fail

diambraArena.bat "ROMSPATH=C:\Users\JOYY\diambraArena\roms\" "PYTHONFILE=diambraArenaGist.py"

DIAMBRAROMSPATH ENV VAR =

Executing in the docker (CPU image):
  Roms path: C:\Users\JOYY\diambraArena\roms\
  GUI Active: 0
  Command: python diambraArenaGist.py
  Current Directory: "C:\Users\JOYY\diambraArena\examples"
  Volume:
--

Namespace(romsPath=None)
EnvId = TestEnv
Action Spaces = multiDiscrete
Use attack buttons combinations = [True, True]
diambraEnv library successfully loaded
Stored credentials found.

-----------------------------------------------------------------------------------------------------------------------------------------------------------------
      .:-:-**#*#####+***+=-:.
 ..-++####+#################=+=:.
:+*#*###########################*-.
   .-+#############################=.
      .-*###########################+.
        .=######++======++*#########*#=. ........ ...     .......     ...........     ........     ........ ............     ............         ...........
          -*=------:---------=*########- .------..-----:. .------.   .-----------.    --------.   :-------- --------------:. --------------:.    :----------:
          .:--------:---------:=#######* .------..-------..------.   :-----:-----:.   ---------. .--------- ------:..:-----: ------:..------:   .------:-----.
        .:------::---::--------:+#######..------. .------..------.  .------.:-----.   ----------.---------- ------:..------. ------:  :-----.  .:-----:.------.
        :-----::.:---:-----::---:######* .------. .------..------. .:-----: .------.  ------:-------------- ------::-----:.. ------:.-----:.   .------..------.
       .--:..  . :::.:.---.-:---.#####*- .------. .------..------. .------.::------:  ------:.-----.:------ ------:  :-----: ------:.:------: .------:.:-------.
        ..:..:::.:::.::....:.::--:####*. .------::------:..------..------:.:::------. ------: .---. :-----: -------::------: ------:  ------: :------..::------:
       .-::::::---...:--. .-.:-::=###+.  .::::::::::::..  .::::::..::::::.   .::::::. ::::::.  .:.  ::::::: ::::::::::::::.  :::::::  ::::::: ::::::.    .::::::
       .--:.   .:--...::. ..::+####*:
       :--:..   .---:...:.   .:+*+:.
       .:---:::----.. ....    .:.
        .:------:..:...  :.
         .......   ..:.  ..


                                                                   DIAMBRA™ | Dueling AI Arena
                                                              https://diambra.ai - info@diambra.ai

                                   Usage of this software is subject to our Terms of Use described at https://diambra.ai/terms

                                                         DIAMBRA™ is a Trade Mark, © Copyright 2018-2022
                                                                              v. 1.0
-----------------------------------------------------------------------------------------------------------------------------------------------------------------


Environment initialization ...
Error: Cannot open "C:\Users\JOYY\diambraArena\roms\kof98umh.zip": No such file or directory.
You need to put the Game rom file in the roms directory.

Error: Cannot open "C:\Users\JOYY\diambraArena\roms\kof98umh.zip": No such file or directory.
You need to put the Game rom file in the roms directory.

------------------------------------------------------------------------------------------------------

        Contact support on DIAMBRA Discord Server: https://discord.gg/tFDS2UN5sv
                                        AND / OR
 Open a ticket on our GitHub repository issue Tracker: https://github.com/diambra/diambraArena/issues

ROM check works

diambraArena.bat "ROMSPATH=C:\Users\JOYY\diambraArena\roms\" "ROMCHECK=kof98umh.zip"

DIAMBRAROMSPATH ENV VAR =

Executing in the docker (CPU image):
  Roms path: C:\Users\JOYY\diambraArena\roms\
  GUI Active: 0
  Command: python -c 'import diambraArena, os; diambraArena.checkGameSha256(os.path.join(os.getenv(\"DIAMBRAROMSPATH\"), \"kof98umh.zip\"))'
  Current Directory: "C:\Users\JOYY\diambraArena\examples"
  Volume:
--

Correct ROM file for The King Of Fighters '98 UMH, sha256 = beb7bdea87137832f5f6d731fd1abd0350c0cd6b6b2d57cab2bedbac24fe8d0a

diambraArenaGist.py

import diambraArena
import argparse

parser = argparse.ArgumentParser()
parser.add_argument('--romsPath', type=str, required=False, help='Absolute path to roms')
opt = parser.parse_args()
print(opt)

# Mandatory settings
settings = {}
# Game selection
settings["gameId"] = "kof98umh"
settings["romsPath"] = "C:\\Users\\JOYY\\diambraArena\\roms\\"
# if opt.romsPath is not None:
#     # Path to roms folder
#     settings["romsPath"] = opt.romsPath

env = diambraArena.make("TestEnv", settings)

observation = env.reset()

while True:

    actions = env.action_space.sample()

    observation, reward, done, info = env.step(actions)

    if done:
        observation = env.reset()
        break

env.close()

[diambra]

We're on it. We'll keep you posted.

[diambra]

This problem is caused by the addition of settings["romsPath"] to the script.
In Docker executions, that parameter should never be added. We will improve robustness adding a check.

Removing that setting, all works fine as expected.

[diambra]

Commit 472913f adds the robustness check to avoid this to happen again.