Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_sheet_localize_action.rb Option #1

Open
madjuju opened this issue May 15, 2019 · 13 comments
Open

google_sheet_localize_action.rb Option #1

madjuju opened this issue May 15, 2019 · 13 comments

Comments

@madjuju
Copy link

madjuju commented May 15, 2019

It should be nice to be able to do not generate CD DATA and export only strings
google_sheet_localize_action.rb.zip

after each update l must remove in google_sheet_localize_action.rb

CD DATA references

@madjuju
Copy link
Author

madjuju commented Sep 26, 2019

@mariohahn ping ?

@mariohahn
Copy link
Collaborator

oh I haven't seen that issue, will look into it the next days

@madjuju
Copy link
Author

madjuju commented Sep 21, 2020

@mariohahn hello Ping ?

@madjuju
Copy link
Author

madjuju commented Dec 30, 2020

Could you please check it ?

@madjuju
Copy link
Author

madjuju commented Apr 6, 2021

@mariohahn Could you please have a look ?

@mariohahn
Copy link
Collaborator

Hi, can you send me a PR? (:

@AlexGrafl
Copy link

Why would you need to remove CDATA?

@madjuju
Copy link
Author

madjuju commented Apr 14, 2021

Why would you need to remove CDATA?

@AlexGrafl

to do not have it in string.xml in android studio

@madjuju
Copy link
Author

madjuju commented Apr 14, 2021

@AlexGrafl because UNREADABLE

before :
113889499-95a57e80-97c3-11eb-9e36-4cd998e64e7f

after

113889293-642cb300-97c3-11eb-867f-fd219ad011a2

@AlexGrafl
Copy link

I don't know, seems reasonably readable to me.

Using this plugin you should manage your strings in the Google Sheet anyways and not have to look into the strings.xml most of the times.

@madjuju
Copy link
Author

madjuju commented Apr 14, 2021

@AlexGrafl right for the google sheet.

However, when debugging and testing, it's not clear, as I have 6 different languages for each application.

@AlexGrafl
Copy link

Well I'm still not convinced, it's just the <CDATA[[ tag.

But if you insist, feel free to implement an option for the Android variant to be able to exclude the CDATA tags and open a PR.

@madjuju
Copy link
Author

madjuju commented Apr 14, 2021

@AlexGrafl as l said in my PR l did it but not to much developper to set it as feature flag or option
#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants