-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CDATA #8
base: master
Are you sure you want to change the base?
Remove CDATA #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the use-case be to require the CDATA to be removed from the android string resources altogether?
The CDATA tag helps us to not have to escape special characters which would be interpreted by the XML parser within the string, so that while inserting translations into the spreadsheet, one would not need to escape e.g. <
or >
manually.
Is your use-case that you have those special characters already escaped manually in the respective localization sheet?
As this would (imho) be a breaking change, as all already existing localization sheets would need to be updated to manually escape those special characters, I would more see this as maybe a configuration option / feature flag, instead of changing the default behavior.
@FlowMo7 I don't have a problem with special characters, except maybe for & |
But if you would have a language with the need of escaping characters, you would run into an issue without the CDATA. It the google sheet not the better place to check the Strings anyway? If you would really like to have it like that please send me a PR, where you can set Remove_CDATA as a parameter, because as @FlowMo7 mentioned, for us, it is a very important "feature" and it would be a breaking change. |
@mariohahn I am not competent enough to code this feature |
No description provided.