fixed argument sorting #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmayerhofer
approved these changes
Mar 18, 2021
| end | ||
|
|
||
| result = result.sort_by! { |k| k["offset"] }.reverse! |
There was a problem hiding this comment.
Suggested change
| result = result.sort_by! { |k| k["offset"] }.reverse! | |
| result = result.sort_by! { |k| -k["offset"] } |
There was a problem hiding this comment.
I tried that :D it crashed, I have no plan why :D
There was a problem hiding this comment.
(tests would also be nice, but none are setup for this project)
There was a problem hiding this comment.
Sure, atm I have my local tests, you can see the fastlane lanes. No Unit tests, but hey, at least I test it :D
There was a problem hiding this comment.
Aber ja da gibt es sicher Verbesserungspotential
oanhof
approved these changes
Mar 18, 2021
tkoller
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im moment war die Sortierung der Argument teilweise falsch.
of %d %s used ergab -> func markusTest(_ arg0: String, _ arg1: Int) -> String
jetzt ergibt es richtigerweise:
of %d %s used ergab -> func markusTest(_ arg0: Int, _ arg1: String) -> String