Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Update more endpoints to Discord API v9 #230

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

samhza
Copy link
Contributor

@samhza samhza commented Jun 17, 2021

Update message editing/sending for both API and webhooks.

@samhza
Copy link
Contributor Author

samhza commented Jun 17, 2021

The embed field for editing/sending messages has been deprecated in favor of an embeds field, allowing for sending/editing multiple embeds in one message. Should EditMessage/EditEmbed's API be kept the same but internally using Embeds: &[]discord.Embed{embed} instead of Embed: embed? Either way, I think we should remove the Embed field from {Send,Edit}MessageData.

https://discord.com/developers/docs/resources/channel#create-message

@diamondburned
Copy link
Owner

@samhza

I agree that we should remove the singular Embed field and use the multiple one instead.

api/message.go Outdated Show resolved Hide resolved
api/message.go Outdated Show resolved Hide resolved
api/message.go Outdated Show resolved Hide resolved
utils/sendpart/sendpart.go Outdated Show resolved Hide resolved
utils/sendpart/sendpart.go Outdated Show resolved Hide resolved
api.{Send,Edit}MessageData and their equivalents in package api/webhook
have been updated to add some fields added in Discord API v9.
(webhook.Client).EditMessage now also returns a message, because that
endpoint returns a message on success.
@diamondburned diamondburned merged commit 37b8871 into diamondburned:v3 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants