You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, Request retries on any HTTP Response status that is < 200 or > 299.
However, many errors won't get resolved by a retry, as only 5xx errors indicate a server error and any other status indicates either an error with the data that was sent, etc..
An exception to this is of course code 429 - too many requests which indicates rate limiting.
See also https://en.wikipedia.org/wiki/List_of_HTTP_status_codes.
I would propose to check for server or rate limit errors and retry only then, but let all others break the loop and get handled respectively.
This could be done by simply replacing the
Regarding:
httputil.Client.Request
Currently,
Request
retries on any HTTP Response status that is< 200
or> 299
.However, many errors won't get resolved by a retry, as only 5xx errors indicate a server error and any other status indicates either an error with the data that was sent, etc..
An exception to this is of course code
429 - too many requests
which indicates rate limiting.See also https://en.wikipedia.org/wiki/List_of_HTTP_status_codes.
I would propose to check for server or rate limit errors and retry only then, but let all others break the loop and get handled respectively.
This could be done by simply replacing the
with
.
If you create a branch for it, I can hand in a PR for it.
The text was updated successfully, but these errors were encountered: