v3: discord, api, gateway: add per-guild avatars #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavolin
suggested changes
Sep 28, 2021
mavolin
suggested changes
Sep 28, 2021
api/user.go
Outdated
| // ModifyMe modifies the requester's user account settings. | ||
| func (c *Client) ModifyMe(data ModifySelfData) (*discord.User, error) { | ||
| // ModifyCurrentUser modifies the requester's user account settings. | ||
| func (c *Client) ModifyCurrentUser(data ModifySelfData) (*discord.User, error) { |
There was a problem hiding this comment.
ModifySelfData should also be renamed to ModifyCurrentUserData.
There was a problem hiding this comment.
woops, forgot about that!
starshine-sys
force-pushed
the
guild-avatars
branch
from
c37c796
to
56e8330
Compare
mavolin
approved these changes
Sep 28, 2021
diamondburned
approved these changes
Sep 28, 2021
diamondburned
pushed a commit
that referenced
this pull request
Nov 4, 2021
* v3: discord, api, gateway: add per-guild avatars * api: rename ModifyMe to ModifyCurrentUser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: discord/discord-api-docs#3081
(Had to break the pattern established by User.AvatarURL() and Guild.IconURL() etc, as the member object doesn't include a guild ID)