Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: fix #27 #28

Merged
merged 2 commits into from
May 8, 2020
Merged

API: fix #27 #28

merged 2 commits into from
May 8, 2020

Conversation

mavolin
Copy link
Contributor

@mavolin mavolin commented May 7, 2020

Closes #27.

@mavolin
Copy link
Contributor Author

mavolin commented May 7, 2020

I also found that the ErrEmojiTooLarge variable in the same file is unused. Should I create a commit removing that?

@diamondburned
Copy link
Owner

I also found that the ErrEmojiTooLarge variable in the same file is unused. Should I create a commit removing that?

Yes, that should be removed. I suppose it was meant to be used with image.Validate(), but that already has its own error.

@mavolin
Copy link
Contributor Author

mavolin commented May 7, 2020

Done. Could you, if possible, release a hotfix release for this, as I need this method for a project I am working on.

@diamondburned diamondburned merged commit ca80a52 into diamondburned:master May 8, 2020
@diamondburned
Copy link
Owner

diamondburned commented May 8, 2020 •
edited

Will do as soon as CI passes.

Update: v0.6.3 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: payload for ModifyEmoji always empty
2 participants
@mavolin @diamondburned