Close previous UDP voice sessions on Continue #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diamondburned
approved these changes
Dec 4, 2022
|
I have no clue what this is really doing, but if it works, it works. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, stale UDP voice sessions (i.e. when the region changes or the voice server fails over and a server change notification is sent via the websocket) were never closed, this could leave callers hanging perpetually unless they set a Read/Write timeout. However that's kind of an annoying quirk that can be worked around by just closing the UDP session when appropriate. I'm not sure if
Continueis the right place to close the connection, but it works for me lol. There is probably a more correct location to close the connection? I'm just making this PR to give you an idea I guess.