Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: GuildsRange query fields don't get omitted #36

Closed
mavolin opened this issue May 10, 2020 · 0 comments · Fixed by #51
Closed

API: GuildsRange query fields don't get omitted #36

mavolin opened this issue May 10, 2020 · 0 comments · Fixed by #51

Comments

@mavolin
Copy link
Contributor

mavolin commented May 10, 2020 •
edited

When using GuildsAfter which internally uses GuildsRange it uses 0 as value for before. However, before doesn't get omitted, as it should, but gets send with as part of the query, effectively requesting all guilds with an id < 0, which of course don't exist.
It is possible that discord ignores this (seems unlikely though), as I got these values when mocking the request, but this should get fixed one way or another.

Can hand in a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: GuildsRange query fields don't get omitted
1 participant
@mavolin