Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: add SendMessage for a simple message #49

Closed
mavolin opened this issue May 11, 2020 · 3 comments · Fixed by #61
Closed

API: add SendMessage for a simple message #49

mavolin opened this issue May 11, 2020 · 3 comments · Fixed by #61

Comments

@mavolin
Copy link
Contributor

mavolin commented May 11, 2020

Instead of sending message and embed, just send a message and add an additional SendEmbed method.

Can hand in a PR.
@diamondburned
Copy link
Owner

I don't really want to break the SendMessage API. In fact, I think the current API is perfectly reasonable.

Sorry, I don't really want to change this one.

@mavolin
Copy link
Contributor Author

mavolin commented May 11, 2020 •
edited
Loading

How about a SendSimpleMessage or a SendTextMessage method for just content though? It seems kind of ugly to have a nil parameter for every message.
Also a SendEmbed method just for embeds.

@diamondburned
Copy link
Owner

I'm fine with a SendText and a SendEmbed.

@mavolin mavolin mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: add SendMessage for a simple message
2 participants
@diamondburned @mavolin