-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make movie reviews model easier to run #34
Comments
Leaving as-is for now, we should talk to an NLP expert first to see how models are normally used. |
The input to the model should remain text, but the functions to create tokens from the input string will be made part of the model. The goal is to avoid having to define a lot of boilerplate code in the dianna repository just to be able to run the model. |
Draft PR in the exploration repo: dianna-ai/dianna-exploration#147 |
We will not use the simplified model as it doesn't work. This issue can be closed when the simplifications that don't affect the onnx model itself are merged in dianna-exploration. |
@loostrum could you, please, check if this can be closed? |
Currently it needs quite a lof of code to run; most of that can be made part of the model itself.
This would allow for easy use of the model in tests as well
The text was updated successfully, but these errors were encountered: