-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert our model(s) from onnx to tf #56
Comments
use |
Explored it with a single model (leafsnap) and predictions were equivalent to the original onnx. Script can be found here: |
Can somebody who has time, please test the Tutorial notebook of onnx-tensorflow executing exactly the same notebook and just appending it with the shap step to see if it works? |
That tutorial didn't work for me even without changing anything, the model they provide fails when running I did do some tests together with Chris and Yang, see this notebook: https://github.com/dianna-ai/dianna-exploration/blob/test-shap-tf-onnx/onnx_conversion_scripts/test_shap_tf_onnx.ipynb |
2 remarks:
|
Note that the relevant branches are in |
My interpretations of the errors we got in https://github.com/dianna-ai/dianna-exploration/blob/test-shap-tf-onnx/onnx_conversion_scripts/test_shap_tf_onnx.ipynb: For our model- the warning after cell [21] about exporting a tensor dict might be related to the error later after cell [24]:
Looks like versioning issues indeed. But maybe we can try not with mnist. but another or our models? I recall @geek-yang saying the mnist had a different structure after conversion than the others. For the native Keras model: I can report our error also in their issue, hoping someone will pay attention. Also worth looking at how the skomatin guy changed his model and avoided the error (post from 11 Sep 2020). He thinks shap does not support TF 2.0 :-( @loostrum what shap and TF versions did you use? |
One more tough: if DeepExplainer attempts ultimately fail, any point of trying the slower Shap's KernalExplainer? |
I tried the latest version of shap (0.40), a slightly older version (0.38) and the latest master branch. |
No description provided.
The text was updated successfully, but these errors were encountered: