Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create notebook using DIANNA on the ecoextreml model and data #759

Closed
cwmeijer opened this issue May 15, 2024 · 4 comments · Fixed by #811
Closed

create notebook using DIANNA on the ecoextreml model and data #759

cwmeijer opened this issue May 15, 2024 · 4 comments · Fixed by #811
Assignees

Comments

@cwmeijer
Copy link
Contributor

No description provided.

@SarahAlidoost SarahAlidoost changed the title create notebook using DIANNA on the eco3dxl model and data create notebook using DIANNA on the ecoextreml model and data May 15, 2024
@SarahAlidoost SarahAlidoost self-assigned this Jun 5, 2024
@SarahAlidoost SarahAlidoost added the standup Temp label- for disscussion with the team next standup label Jun 18, 2024
@elboyran
Copy link
Contributor

elboyran commented Aug 15, 2024

@SarahAlidoost, nice work! I'm only not able to see the result figures in the Review Notebook mode.

Please, don't forget to also update the Datasets, Models and Tutorials table in the main README and the task and tutorial tables in the Tutorial's README with links related to the new tutorial!

For the sake of budget saving, I could also do this (with a possible small help to locate the data and model links), after a successful PR merge (passing all checks).

@SarahAlidoost
Copy link
Contributor

@SarahAlidoost, nice work! I'm only not able to see the result figures in the Review Notebook mode.

Thanks, I also noticed that the figures are not rendered correctly. It is fixed now.

Please, don't forget to also update the Datasets, Models and Tutorials table in the main README and the task and tutorial tables in the Tutorial's README with links related to the new tutorial!

For the sake of budget saving, I could also do this (with a possible small help to locate the data and model links), after a successful PR merge (passing all checks).

In PR #811, I added the items to the section below, can you please help to complete them:

Datasets in main README: can you help with an image for Examples cell?
Models in main README: done
Tutorials table in main README: done
task in Tutorial's README: can you help with an image for Logo cell?
tutorial in Tutorial's README: can you help with logo and collab link?

@elboyran
Copy link
Contributor

elboyran commented Aug 21, 2024

@SarahAlidoost , sure I can help.

I have made some commits to address the help you have asked for (in the process also fixing some old broken links in the READMEs.

IMHO there is still a little bit of final polishing needed, namely (sorry for forgetting some of them in the issue/comments before):

  • add the used hyperparameters in the KernalSHAP hyperparameter table
  • Adding a word explaining what the physical model is for in the task description table
  • Adding 1 sentence to the notebook introduction paragraph summarizing very briefly what the scientific problem to be helped by the model is. You have given nice references, but a single sentence could save interested scientists the time to dig and read the whole paper. Sorry, I didn't feel competent to make such a sentence myself from e.g. the eEcoExtremeML project description.

@elboyran elboyran removed the standup Temp label- for disscussion with the team next standup label Aug 21, 2024
@SarahAlidoost
Copy link
Contributor

@SarahAlidoost , sure I can help.

I have made some commits to address the help you have asked for (in the process also fixing some old broken links in the READMEs.

IMHO there is still a little bit of final polishing needed, namely (sorry for forgetting some of them in the issue/comments before):

  • add the used hyperparameters in the KernalSHAP hyperparameter table
  • Adding a word explaining what the physical model is for in the task description table
  • Adding 1 sentence to the notebook introduction paragraph summarizing very briefly what the scientific problem to be helped by the model is. You have given nice references, but a single sentence could save interested scientists the time to dig and read the whole paper. Sorry, I didn't feel competent to make such a sentence myself from e.g. the eEcoExtremeML project description.

@elboyran thanks. I addressed your comments in the last three commits #811. Please let me know if we can merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants