Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming and attribution for port of code #52

Closed
EliotJones opened this issue Sep 12, 2018 · 1 comment
Closed

Naming and attribution for port of code #52

EliotJones opened this issue Sep 12, 2018 · 1 comment

Comments

@EliotJones
Copy link
Contributor

Hi, I've ported this library to C# since I've been doing some work which required sentence boundary detection in C#.

Link

I wanted to check what you would like in terms of attribution and naming of the project.

Currently it is called PragmaticSegmenterNet but if you wanted it to use a name that was less directly linked then I'd be happy to do this.

Also I have no understanding of how licenses work so I wanted to check you were happy with the license format below:

The MIT License (MIT)

Original work Copyright (c) 2015 Kevin S. Dias
Modified work Copyright (c) 2017 UglyToad

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

But I have no idea if this is the correct way to manage this situation so let me know if you wanted some other form of license text. I've included attribution in the README but if it would also be polite to provide attribution in some kind of Notices.txt file or similar please let me know.

I hope to feed back any changes or bug-fixes to the Ruby code as I make any further modifications. Please let me know if this is useful or you'd rather avoid this.

Feel free to close this issue straight away. Thanks, Eliot

@diasks2
Copy link
Owner

diasks2 commented Sep 12, 2018

Cool! That's great. I also don't have much understanding with how licenses work so what you have seems fine to me. No complaints here. We should add a link to your library in the README of this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants