Skip to content

Commit

Permalink
Add @nophantomjs tag to default cucumber profile
Browse files Browse the repository at this point in the history
Use this tag for tests which can't work with PhantomJS, but which we
can run with Selenium using some other profile (not implemented here).

closes #6418
  • Loading branch information
cmrd-senya authored and SuperTux88 committed Feb 17, 2018
1 parent b32c844 commit 3e31b91
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions Changelog.md
Expand Up @@ -6,6 +6,7 @@
## Bug fixes

## Features
* Add basic html5 audio/video embedding support [#6418](https://github.com/diaspora/diaspora/pull/6418)

# 0.7.3.1

Expand Down
4 changes: 2 additions & 2 deletions config/cucumber.yml
Expand Up @@ -9,11 +9,11 @@ screenshot_opts = "--require features --format pretty"
%>

# 'normal' test runs
default: <%= std_opts %> -r features
default: <%= std_opts %> -r features --tags ~@nophantomjs
wip: -r features --tags @wip:3 --wip features
rerun: <%= rerun_opts %> --format rerun --out rerun.txt --strict --tags ~@wip --tags ~@screenshots

# screenshot feature
ref_screens: "<%= screenshot_opts %> --tags @reference-screenshots"
cmp_screens: "<%= screenshot_opts %> --tags @comparison-screenshots"
all_screens: "<%= screenshot_opts %> --tags @screenshots"
all_screens: "<%= screenshot_opts %> --tags @screenshots"
2 changes: 2 additions & 0 deletions features/desktop/media-embed.feature
@@ -1,3 +1,5 @@
# We can create a separate cucumber profile that will run these tests with Selenium
@nophantomjs
@javascript
Feature: oembed
In order to make videos easy accessible
Expand Down

0 comments on commit 3e31b91

Please sign in to comment.