User should be able to edit posts #1762

Open
Yajo opened this Issue Aug 12, 2011 · 114 comments

Comments

Projects
None yet
@Yajo

Yajo commented Aug 12, 2011

Sometimes you write a post and after posting you realize that it has some error, or that you posted it into the wrong aspects.

I think there should be an 'edit' option for both cases, so you don't have to delete and rewrite or reshare it to another aspect.


There is a $320 open bounty on this issue. Add to the bounty at Bountysource.

@ghost

This comment has been minimized.

Show comment
Hide comment

ghost commented Sep 1, 2011

+1

@Nygu

This comment has been minimized.

Show comment
Hide comment
@Nygu

Nygu Sep 3, 2011

This is a very common request among new users and should be implemented. Freedom and user rights!

Also, the ability to edit your comments.

Nygu commented Sep 3, 2011

This is a very common request among new users and should be implemented. Freedom and user rights!

Also, the ability to edit your comments.

@heavyboots

This comment has been minimized.

Show comment
Hide comment
@heavyboots

heavyboots Sep 5, 2011

+1 Indeed.

A major reason for this is that a post with a lot of formatting can currently require a huge amount of work to delete and repost just to fix one small punctuation or spelling error. Very frustrating for the user.

+1 Indeed.

A major reason for this is that a post with a lot of formatting can currently require a huge amount of work to delete and repost just to fix one small punctuation or spelling error. Very frustrating for the user.

@bdjnk

This comment has been minimized.

Show comment
Hide comment
@bdjnk

bdjnk Sep 25, 2011

Contributor

My two cents on how to implement post and comment editing sanely.

Obviously editing is desirable, but what about people breaking the conversation by changing something others have responded to in some way? Perhaps people who've commented, liked, or reshared should be notified and those who've reshared should have the option to update their reshare. In such a system notifications should only go out for significant changes, meaning more then just typo corrections. This could be defined as an amount of differences when compared but that would leave the system open to certain critical keyword changes though, like the word "not" or the prefix "un". If these keywords or prefixes are added or removed that could be monitored and also cause a major change notification. And if anyone felt like the notifications were too much there could always be an option to disable them.

I really would work on this myself but I'm starting school again shortly. No rest for the erudite.

Contributor

bdjnk commented Sep 25, 2011

My two cents on how to implement post and comment editing sanely.

Obviously editing is desirable, but what about people breaking the conversation by changing something others have responded to in some way? Perhaps people who've commented, liked, or reshared should be notified and those who've reshared should have the option to update their reshare. In such a system notifications should only go out for significant changes, meaning more then just typo corrections. This could be defined as an amount of differences when compared but that would leave the system open to certain critical keyword changes though, like the word "not" or the prefix "un". If these keywords or prefixes are added or removed that could be monitored and also cause a major change notification. And if anyone felt like the notifications were too much there could always be an option to disable them.

I really would work on this myself but I'm starting school again shortly. No rest for the erudite.

@maxwell

This comment has been minimized.

Show comment
Hide comment
@maxwell

maxwell Oct 7, 2011

Member

I think for the current set of things (status messages) we will not support editing of posts. maybe if will pull in some "notes" functionality, but not for right now.

Member

maxwell commented Oct 7, 2011

I think for the current set of things (status messages) we will not support editing of posts. maybe if will pull in some "notes" functionality, but not for right now.

@maxwell maxwell closed this Oct 7, 2011

@danielgrippi danielgrippi reopened this Oct 12, 2011

@pravi

This comment has been minimized.

Show comment
Hide comment
@pravi

pravi Oct 12, 2011

Member

bdjnk, like in digg.com we can have a counter of say 60 seconds for editing, which covers the common use case of typos or wanting to change aspects.

Member

pravi commented Oct 12, 2011

bdjnk, like in digg.com we can have a counter of say 60 seconds for editing, which covers the common use case of typos or wanting to change aspects.

@tanghus

This comment has been minimized.

Show comment
Hide comment
@tanghus

tanghus Oct 12, 2011

Maybe just a preview perhaps reusing code from http://daringfireball.net/projects/markdown/dingus

tanghus commented Oct 12, 2011

Maybe just a preview perhaps reusing code from http://daringfireball.net/projects/markdown/dingus

@pravi

This comment has been minimized.

Show comment
Hide comment
@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 13, 2011

Contributor

Here's an idea I discussed with sarahmei and others in IRC:

Have some delay before a message is actually posted. The amount of delay can be a setting someplace, either in the user settings, or server-side config. Instead of posting right away, enter the post in a queue. During this window of time, the user can edit his/her post to his/her heart's content. Once the delay is finished, actually do the posting. This way, the fears of the core devs are pretty much allayed (correct me if I'm wrong on that), and the users get an edit facility.

Implementation details are up in the air, and open for discussion. Say, a timestamp column on the posts table. post_by or whatever. Something to indicate that this post has or has not gone out yet. So, a not-yet-posted post is visible only to the author, and otherwise appears indistinguishable from a normal post, other than having an Edit button or link.

If the delay amount is put in the user settings, then users can choose how much delay they want, so people can choose to have their posts go out straight away, while others can elect to have a window of editability, at the cost of delayed posting.

You don't necessarily have to explain the mechanics of all this to non-techie users. For most intents and purposes, everything will feel the same, except they get a brilliant new Edit facility that they've been clamouring for since forever.

Contributor

Pistos commented Oct 13, 2011

Here's an idea I discussed with sarahmei and others in IRC:

Have some delay before a message is actually posted. The amount of delay can be a setting someplace, either in the user settings, or server-side config. Instead of posting right away, enter the post in a queue. During this window of time, the user can edit his/her post to his/her heart's content. Once the delay is finished, actually do the posting. This way, the fears of the core devs are pretty much allayed (correct me if I'm wrong on that), and the users get an edit facility.

Implementation details are up in the air, and open for discussion. Say, a timestamp column on the posts table. post_by or whatever. Something to indicate that this post has or has not gone out yet. So, a not-yet-posted post is visible only to the author, and otherwise appears indistinguishable from a normal post, other than having an Edit button or link.

If the delay amount is put in the user settings, then users can choose how much delay they want, so people can choose to have their posts go out straight away, while others can elect to have a window of editability, at the cost of delayed posting.

You don't necessarily have to explain the mechanics of all this to non-techie users. For most intents and purposes, everything will feel the same, except they get a brilliant new Edit facility that they've been clamouring for since forever.

@KaiMartin

This comment has been minimized.

Show comment
Hide comment
@KaiMartin

KaiMartin Oct 13, 2011

+1 to the idea of a limited time for editing.
How about a little more sophistication: Let the post appear to other users in the interim time but clearly mark it as "preliminary". That way, communication is not artificially delayed. But Bob knows that Alice may still apply some changes. Bonus points to let the user choose the length of this interval (within a reasonable range).

This would make me feel much more in control, both as an author and as a reader.

---<)kaimartin(>---

+1 to the idea of a limited time for editing.
How about a little more sophistication: Let the post appear to other users in the interim time but clearly mark it as "preliminary". That way, communication is not artificially delayed. But Bob knows that Alice may still apply some changes. Bonus points to let the user choose the length of this interval (within a reasonable range).

This would make me feel much more in control, both as an author and as a reader.

---<)kaimartin(>---

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 13, 2011

Contributor

If it's already "somewhat out", then all the coding troubles are let into the bag. There needs to be only two states: "not out at all yet", and "fully out, no turning back".

Anyway, it could be a moot point. I've been talking with Daniel Grippi, and I have reason to believe full on editing may be coming sooner rather than later, and that the technical issues are not that big a deal because a lot of code is already in place.

Contributor

Pistos commented Oct 13, 2011

If it's already "somewhat out", then all the coding troubles are let into the bag. There needs to be only two states: "not out at all yet", and "fully out, no turning back".

Anyway, it could be a moot point. I've been talking with Daniel Grippi, and I have reason to believe full on editing may be coming sooner rather than later, and that the technical issues are not that big a deal because a lot of code is already in place.

@Libreman

This comment has been minimized.

Show comment
Hide comment
@Libreman

Libreman Oct 13, 2011

The ability to edit posts/comments needs careful considerations - a lot of issues need to be considered.

For example I do not want posts that I already commented on to change, that opens the possibility that the thing I was commenting on is modified, put into different context etc. and then my comment would look out of place at best and completely ridiculous and/or silly at worst.

The solution to that issue would be to allow edits only if there are no comments on that post yet for example but that would defeat the purpose people are demanding it for to a large degree.

I found that I wanted to edit posts predominantly when I screwed up markdown syntax (very easy to do btw) so I would suggest implementing a different feature that could solve the source problem that keeps people requesting an edit feature - make Diaspora preview the post with markdown rendered for review before posting, that way people could catch most typos and markdown mistakes before they actually post them and the need for edit would largely diminish. Also it would allow those who do not want such an assistance to simply turn it off. So this is what I would propose as a relatively quick fix and we'll see whether edit will be still necessary after this ...

The ability to edit posts/comments needs careful considerations - a lot of issues need to be considered.

For example I do not want posts that I already commented on to change, that opens the possibility that the thing I was commenting on is modified, put into different context etc. and then my comment would look out of place at best and completely ridiculous and/or silly at worst.

The solution to that issue would be to allow edits only if there are no comments on that post yet for example but that would defeat the purpose people are demanding it for to a large degree.

I found that I wanted to edit posts predominantly when I screwed up markdown syntax (very easy to do btw) so I would suggest implementing a different feature that could solve the source problem that keeps people requesting an edit feature - make Diaspora preview the post with markdown rendered for review before posting, that way people could catch most typos and markdown mistakes before they actually post them and the need for edit would largely diminish. Also it would allow those who do not want such an assistance to simply turn it off. So this is what I would propose as a relatively quick fix and we'll see whether edit will be still necessary after this ...

@Libreman

This comment has been minimized.

Show comment
Hide comment
@Libreman

Libreman Oct 14, 2011

An issue dealing with preview function has been created here: #2108

An issue dealing with preview function has been created here: #2108

@h6w

This comment has been minimized.

Show comment
Hide comment
@h6w

h6w Oct 14, 2011

As a workaround in the meantime, just delete and create a new one. Copy and paste, people! :-D

One day D* will have all the good features of Google Wave, but not today.

h6w commented Oct 14, 2011

As a workaround in the meantime, just delete and create a new one. Copy and paste, people! :-D

One day D* will have all the good features of Google Wave, but not today.

@Libreman

This comment has been minimized.

Show comment
Hide comment
@Libreman

Libreman Oct 14, 2011

yeah, that's the easiest solution ... I personally do not miss an edit feature, there is a reason it's not on FB and G+

but the problem with deleting it and posting again fixed right now is that you do not get to copy the markdown syntax so you need to actually replicate it again manually if you want it to look the same which is just a pain in the a$$, hard to say what the solution for that could be ... I'm for the preview feature and if people can not get the post right then - I think they need look for failure somewhere else than Diaspora itself instead of demanding an edit function ... like the cough_mirror_cough ;)

Just see how it is implemented here on github, you have "write" tab and a "preview" tab ... why not do the same for Diaspora with the ability to automatically switch to preview for review before posting? It sounds reasonable enough ...

yeah, that's the easiest solution ... I personally do not miss an edit feature, there is a reason it's not on FB and G+

but the problem with deleting it and posting again fixed right now is that you do not get to copy the markdown syntax so you need to actually replicate it again manually if you want it to look the same which is just a pain in the a$$, hard to say what the solution for that could be ... I'm for the preview feature and if people can not get the post right then - I think they need look for failure somewhere else than Diaspora itself instead of demanding an edit function ... like the cough_mirror_cough ;)

Just see how it is implemented here on github, you have "write" tab and a "preview" tab ... why not do the same for Diaspora with the ability to automatically switch to preview for review before posting? It sounds reasonable enough ...

@jacius

This comment has been minimized.

Show comment
Hide comment
@jacius

jacius Oct 14, 2011

For the people that are concerned that a post could be edited later to make your comment look bad... consider that almost every blog, most forums, and many other kinds of web services allow the author to edit posts after they are published. It is almost never abused; mostly it is just used to correct errors or provide updates. For example, an article on CNN.com covering a protest might be updated several times a day with new info. It would be incredibly restrictive if they weren't allowed to do that once someone had posted a comment!

Even GitHub allows editing posts later. Someone on the Diaspora project could change this issue to say "Please add a button that murders kittens", and thus make @jeffkloy and @Nygu and @heavyboots seem to be in favor of kitten murder. But that would be a ridiculous and juvenile thing to do, and the person who changed the issue would lose credibility.

In other words, I think people are much too concerned about the possibility of posts being changed to make commentors look bad. That's a hypothetical problem that happens very rarely with existing, similar web services. But, being unable to fix or update your own post is a very real problem that many Diaspora users face every day. It causes a lot of frustration, and makes Diaspora a much less useful platform.

jacius commented Oct 14, 2011

For the people that are concerned that a post could be edited later to make your comment look bad... consider that almost every blog, most forums, and many other kinds of web services allow the author to edit posts after they are published. It is almost never abused; mostly it is just used to correct errors or provide updates. For example, an article on CNN.com covering a protest might be updated several times a day with new info. It would be incredibly restrictive if they weren't allowed to do that once someone had posted a comment!

Even GitHub allows editing posts later. Someone on the Diaspora project could change this issue to say "Please add a button that murders kittens", and thus make @jeffkloy and @Nygu and @heavyboots seem to be in favor of kitten murder. But that would be a ridiculous and juvenile thing to do, and the person who changed the issue would lose credibility.

In other words, I think people are much too concerned about the possibility of posts being changed to make commentors look bad. That's a hypothetical problem that happens very rarely with existing, similar web services. But, being unable to fix or update your own post is a very real problem that many Diaspora users face every day. It causes a lot of frustration, and makes Diaspora a much less useful platform.

@heavyboots

This comment has been minimized.

Show comment
Hide comment
@heavyboots

heavyboots Oct 15, 2011

Yep, this sums it up perfectly. Thanks @jacius for taking the time to write it up!

Some forum software posts a note that "This message has been edited on [timestamp]." if someone else has already commented after you try and edit your post, but I think that's the maximum extent that the devs might optionally go to in order to fix the post-comment editing issue.

Yep, this sums it up perfectly. Thanks @jacius for taking the time to write it up!

Some forum software posts a note that "This message has been edited on [timestamp]." if someone else has already commented after you try and edit your post, but I think that's the maximum extent that the devs might optionally go to in order to fix the post-comment editing issue.

@Libreman

This comment has been minimized.

Show comment
Hide comment
@Libreman

Libreman Oct 16, 2011

The CNN example is not very good one because that's exactly why I'm wary of any edit feature in a first place, I'm aware of several instances that news organizations edited their article, sometimes without any notice, after a part of it was discovered to be controversial and going viral.

But Diaspora is a very different context too, someone being silly on Diaspora doesn't compare to a news organization doing the same, both in the impact or gravity. The problem comes when diaspora becomes a news source like Twitter, does Twitter allow for posts being edited?

I'm not categorically opposing an edit feature, just wondering whether it is really worth it. And if it should be implemented then at least some basic safeguards should be in place for it - be it in a form of time limit on edits, no edit after comment or even a versioning for posts (the ability to see the history of changes)

The CNN example is not very good one because that's exactly why I'm wary of any edit feature in a first place, I'm aware of several instances that news organizations edited their article, sometimes without any notice, after a part of it was discovered to be controversial and going viral.

But Diaspora is a very different context too, someone being silly on Diaspora doesn't compare to a news organization doing the same, both in the impact or gravity. The problem comes when diaspora becomes a news source like Twitter, does Twitter allow for posts being edited?

I'm not categorically opposing an edit feature, just wondering whether it is really worth it. And if it should be implemented then at least some basic safeguards should be in place for it - be it in a form of time limit on edits, no edit after comment or even a versioning for posts (the ability to see the history of changes)

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 16, 2011

Contributor

Versioning would be best as far as social safety is concerned, but that could get resource intensive.

Contributor

Pistos commented Oct 16, 2011

Versioning would be best as far as social safety is concerned, but that could get resource intensive.

@heavyboots

This comment has been minimized.

Show comment
Hide comment
@heavyboots

heavyboots Oct 17, 2011

A simple Quote feature would probably serve the same functionality if it's not already there.

You think someone is likely to "take back" what they said, quote it in your comment. (Assuming comments aren't delete-able by OP, which I don't know about either.)

At the very least, I would say there needs to be the ability to preview what you are about to post with the markdown rendered and in the exact same width & colors that it will appear in the final version. For reasons unknown to me, I simply can't see some errors in a comment box that are immediately evident as soon as I hit Post and see it in "on the page", as it were.

A simple Quote feature would probably serve the same functionality if it's not already there.

You think someone is likely to "take back" what they said, quote it in your comment. (Assuming comments aren't delete-able by OP, which I don't know about either.)

At the very least, I would say there needs to be the ability to preview what you are about to post with the markdown rendered and in the exact same width & colors that it will appear in the final version. For reasons unknown to me, I simply can't see some errors in a comment box that are immediately evident as soon as I hit Post and see it in "on the page", as it were.

@Yajo

This comment has been minimized.

Show comment
Hide comment
@Yajo

Yajo Oct 17, 2011

Maybe with preview + quick syntax guide + delayed post, edition will not be needed. You can always un-say something using the comments...

Yajo commented Oct 17, 2011

Maybe with preview + quick syntax guide + delayed post, edition will not be needed. You can always un-say something using the comments...

@aestetix

This comment has been minimized.

Show comment
Hide comment
@aestetix

aestetix Oct 19, 2011

I strongly support editing of posts. As someone who often writes rather long or controversial articles, I need the agency to be able to put in corrections, fix typos, and update news. It's much easier to be able to point people at a single article than at an initial attempt and a long string of corrections.

One way I'd suggest to work around very valid issues brought up (such as someone editing a post in response to a comment): allow any kind of editing for either a time period (maybe five minutes?) or until someone makes a comment. Once this has happened, after editing, place a note at the bottom of the post showing that it has been edited, and the time of the edit per timezone. That way if someone tries to edit a post to reflect a comment, the timestamp will reflect that.

(For the record, I had to come back to this entry and fix two typos. If I have to do this for an issue comment, I certainly need it to make public posts)

I strongly support editing of posts. As someone who often writes rather long or controversial articles, I need the agency to be able to put in corrections, fix typos, and update news. It's much easier to be able to point people at a single article than at an initial attempt and a long string of corrections.

One way I'd suggest to work around very valid issues brought up (such as someone editing a post in response to a comment): allow any kind of editing for either a time period (maybe five minutes?) or until someone makes a comment. Once this has happened, after editing, place a note at the bottom of the post showing that it has been edited, and the time of the edit per timezone. That way if someone tries to edit a post to reflect a comment, the timestamp will reflect that.

(For the record, I had to come back to this entry and fix two typos. If I have to do this for an issue comment, I certainly need it to make public posts)

@Libreman

This comment has been minimized.

Show comment
Hide comment
@Libreman

Libreman Oct 21, 2011

@aestetix

As someone who often writes rather long or controversial articles

status updates are not intended for "long or controversial articles", just start a blog for that - problem solved! Diaspora should be used only for announcing a new blog post (title + link), not actually posting the blog post as a status update, duh :)

Just thought I point that out - I think the most demand for an edit feature comes from people who are misusing the status update for something it's not intended for, e.g. blog posts :) that's why a character limit would be a good idea IMO, it would remind people that the status update field is actually for, well ... status updates ;)

Then maybe integrate a blog posting into Diaspora in the future but there are specialized solutions for that like Wordpress so it's not high priority really, no need to bastardize Disapora into something it's not supposed to be IMO - keep focus!

@aestetix

As someone who often writes rather long or controversial articles

status updates are not intended for "long or controversial articles", just start a blog for that - problem solved! Diaspora should be used only for announcing a new blog post (title + link), not actually posting the blog post as a status update, duh :)

Just thought I point that out - I think the most demand for an edit feature comes from people who are misusing the status update for something it's not intended for, e.g. blog posts :) that's why a character limit would be a good idea IMO, it would remind people that the status update field is actually for, well ... status updates ;)

Then maybe integrate a blog posting into Diaspora in the future but there are specialized solutions for that like Wordpress so it's not high priority really, no need to bastardize Disapora into something it's not supposed to be IMO - keep focus!

@tanghus

This comment has been minimized.

Show comment
Hide comment
@tanghus

tanghus Oct 21, 2011

Status update? Misuse? I see a field saying: "What's on your mind". Not everything on ones mind can be expressed in a tweet or a dent. Diaspora (and G+) gives you the chance to express something meaningful, and it's annoying when that get's messed up by a typo or a MarkDown error.

tanghus commented Oct 21, 2011

Status update? Misuse? I see a field saying: "What's on your mind". Not everything on ones mind can be expressed in a tweet or a dent. Diaspora (and G+) gives you the chance to express something meaningful, and it's annoying when that get's messed up by a typo or a MarkDown error.

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 21, 2011

Contributor

@Libreman: Your opinion is noted. At the same time, if we can satisfy both sides (long posters and short posters) at the same time, I don't see why we shouldn't.

Anyway, this particular issue (1762) is about editing -- and that includes editing short posts. It should be there, and I do believe it will be -- eventually. In the mean time, post preview is already coded up, the core team just has to take the time to merge (or reject) it.

Contributor

Pistos commented Oct 21, 2011

@Libreman: Your opinion is noted. At the same time, if we can satisfy both sides (long posters and short posters) at the same time, I don't see why we shouldn't.

Anyway, this particular issue (1762) is about editing -- and that includes editing short posts. It should be there, and I do believe it will be -- eventually. In the mean time, post preview is already coded up, the core team just has to take the time to merge (or reject) it.

@aestetix

This comment has been minimized.

Show comment
Hide comment
@aestetix

aestetix Oct 21, 2011

@Libreman I think it is a grave mistake on the developers part to attempt to control what features should and should not be used for. Rather, watch what people do, both on Diaspora and other places, and figure out good ways to adapt the software protocols to make things easier for them. Listen, and grow the system in tune with your community, or you won't have one for long. Case in point: when Twitter noticed people were using @ replies (as we are in this thread) and writing RT for retweets, they incorporated both into their system to much praise.

Creating a character limit on status updates seems like it would remove one of Diaspora's few strengths, and for no apparent good reason. I've already given a suggestion on how to handle editing (the timestamp). Is there a reason you disagree with that remedy?

@Libreman I think it is a grave mistake on the developers part to attempt to control what features should and should not be used for. Rather, watch what people do, both on Diaspora and other places, and figure out good ways to adapt the software protocols to make things easier for them. Listen, and grow the system in tune with your community, or you won't have one for long. Case in point: when Twitter noticed people were using @ replies (as we are in this thread) and writing RT for retweets, they incorporated both into their system to much praise.

Creating a character limit on status updates seems like it would remove one of Diaspora's few strengths, and for no apparent good reason. I've already given a suggestion on how to handle editing (the timestamp). Is there a reason you disagree with that remedy?

@h6w

This comment has been minimized.

Show comment
Hide comment
@h6w

h6w Oct 21, 2011

I can see a reason not to have long posts. My diaspora stream is already around 2000-3000 words a day. I haven't had to read that much over breakfast since I was doing my postgraduate degree, and I don't enjoy it as much as a result.

I think the issue of length in posts should be addressed somewhere, but not here. I believe it should be in a separate issue. This issue is to do with whether to allow/implement edits or not. We have put forward previews as a temporary-solution-that-works*.

Please be mindful of scope-creep in issues. If you wish to discuss word length in posts, please open a separate issue.

h6w commented Oct 21, 2011

I can see a reason not to have long posts. My diaspora stream is already around 2000-3000 words a day. I haven't had to read that much over breakfast since I was doing my postgraduate degree, and I don't enjoy it as much as a result.

I think the issue of length in posts should be addressed somewhere, but not here. I believe it should be in a separate issue. This issue is to do with whether to allow/implement edits or not. We have put forward previews as a temporary-solution-that-works*.

Please be mindful of scope-creep in issues. If you wish to discuss word length in posts, please open a separate issue.

@aestetix

This comment has been minimized.

Show comment
Hide comment
@aestetix

aestetix Oct 21, 2011

@h6w Google Plus ran into the same problem. They fixed it by creating a "cut" after a paragraph or two, allowing people to click a "show more" link to reveal the rest of the post. Effectively the same approach LJ took.

@h6w Google Plus ran into the same problem. They fixed it by creating a "cut" after a paragraph or two, allowing people to click a "show more" link to reveal the rest of the post. Effectively the same approach LJ took.

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 21, 2011

Contributor

@aestetix: Good examples, re: Twitter @ and RT. I think I like your "auto more link" suggestion. I will run it by the core devs, and if they agree, I will implement that myself.

There currently is a character limit in Diaspora, it is 10,000 characters.

@h6w: I think a good solution to having long posts in one's stream is to be judicious about whom one lets into one's aspects. :) I'm particular about aspect admission for the opposite reason: I want fewer inane posts (or none at all, if possible). My favourites are thought- or discussion-provoking posts, which tend to be mid-sized.

Contributor

Pistos commented Oct 21, 2011

@aestetix: Good examples, re: Twitter @ and RT. I think I like your "auto more link" suggestion. I will run it by the core devs, and if they agree, I will implement that myself.

There currently is a character limit in Diaspora, it is 10,000 characters.

@h6w: I think a good solution to having long posts in one's stream is to be judicious about whom one lets into one's aspects. :) I'm particular about aspect admission for the opposite reason: I want fewer inane posts (or none at all, if possible). My favourites are thought- or discussion-provoking posts, which tend to be mid-sized.

@h6w

This comment has been minimized.

Show comment
Hide comment
@h6w

h6w Oct 22, 2011

@aestetix and @Pistos You miss my point. That is not the topic for this issue. This issue is clearly "Ability to edit posts". Please open another issue if you wish to discuss anything other than that. People looking for issues relating to length of posts would not look for an issue entitled "Ability to edit posts". You are just creating confusion in this issue and others.

h6w commented Oct 22, 2011

@aestetix and @Pistos You miss my point. That is not the topic for this issue. This issue is clearly "Ability to edit posts". Please open another issue if you wish to discuss anything other than that. People looking for issues relating to length of posts would not look for an issue entitled "Ability to edit posts". You are just creating confusion in this issue and others.

@aestetix

This comment has been minimized.

Show comment
Hide comment
@aestetix

aestetix Oct 22, 2011

@h6w it was just a side digression that proved useful. Sorry if it bugged you.

But yes, back to the main point, are there any scenarios in which my suggestion (creating an "last edit:" timestamp) would prove not useful? It seems like that would be a good way to mitigate most problems brought by having edit abilities.

@h6w it was just a side digression that proved useful. Sorry if it bugged you.

But yes, back to the main point, are there any scenarios in which my suggestion (creating an "last edit:" timestamp) would prove not useful? It seems like that would be a good way to mitigate most problems brought by having edit abilities.

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 22, 2011

Contributor

@h6w: Point understood and taken. Sorry about that. :)

Contributor

Pistos commented Oct 22, 2011

@h6w: Point understood and taken. Sorry about that. :)

@Pithikos

This comment has been minimized.

Show comment
Hide comment
@Pithikos

Pithikos Oct 28, 2011

+1 for the timer. My first day in alpha.diaspora and it would save me already two times if there was an edit button. A 60sec timer is the best way I think. That way noone can violate the posts in the ways people before me mentioned.

I would also suggest that once someone edits the post, the timer is reset to 60sec. That way you can edit your own post until it is how you want it. When the timer goes down to 0 then the post becomes visible.

(already edited this post 4 times)

+1 for the timer. My first day in alpha.diaspora and it would save me already two times if there was an edit button. A 60sec timer is the best way I think. That way noone can violate the posts in the ways people before me mentioned.

I would also suggest that once someone edits the post, the timer is reset to 60sec. That way you can edit your own post until it is how you want it. When the timer goes down to 0 then the post becomes visible.

(already edited this post 4 times)

@Bugsbane

This comment has been minimized.

Show comment
Hide comment
@Bugsbane

Bugsbane Oct 28, 2011

I just don't see what the complex issue is here. Just let people edit a post or comment until someone else adds a comment. No time limits. No issue with changing the context. Easy.

I just don't see what the complex issue is here. Just let people edit a post or comment until someone else adds a comment. No time limits. No issue with changing the context. Easy.

@Pithikos

This comment has been minimized.

Show comment
Hide comment
@Pithikos

Pithikos Oct 28, 2011

@Bugsbane that's in fact a good idea. But what if someone comments immedietely? Then you can't edit.

@Bugsbane that's in fact a good idea. But what if someone comments immedietely? Then you can't edit.

@Bugsbane

This comment has been minimized.

Show comment
Hide comment
@Bugsbane

Bugsbane Oct 29, 2011

Correct. However, that's a pretty edge case and like asking what happens if you spot a typo one second after the timer ran out for the other suggestion. Anyway, once people have added comments you get into the whole issue of changing context if you ever let people edit content with later comments, anyway (unless there's a way to see the original revisions, which gets complex, messy and non-simple for users to learn.)

To me this seems like a simple, easy for users to understand, solution that covers people 99.99% of the time.

Correct. However, that's a pretty edge case and like asking what happens if you spot a typo one second after the timer ran out for the other suggestion. Anyway, once people have added comments you get into the whole issue of changing context if you ever let people edit content with later comments, anyway (unless there's a way to see the original revisions, which gets complex, messy and non-simple for users to learn.)

To me this seems like a simple, easy for users to understand, solution that covers people 99.99% of the time.

@Pistos

This comment has been minimized.

Show comment
Hide comment
@Pistos

Pistos Oct 29, 2011

Contributor

From what I know of what the devs have been discussing, the way edit is going to go down is: People will be allowed to edit any time, but a revision history will probably be implemented. One of the major things to deal with is federation of edits. But that's not a showstopper. This will come, in time.

Contributor

Pistos commented Oct 29, 2011

From what I know of what the devs have been discussing, the way edit is going to go down is: People will be allowed to edit any time, but a revision history will probably be implemented. One of the major things to deal with is federation of edits. But that's not a showstopper. This will come, in time.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Sep 12, 2015

@jaywink I will contact the developer this is assigned to in order to start moving forward

@jaywink I will contact the developer this is assigned to in order to start moving forward

@crypdick

This comment has been minimized.

Show comment
Hide comment

crypdick commented Nov 9, 2015

+1!

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Apr 21, 2016

Update: I am sorry for the delay with adding this feature. We initially had plans to finish this improvement and start working on additional features, but the funding source on our end delayed the project that would have funded this development. I just noticed that this Bounty was fully funded. I will reach out to the original developer and ask him to complete this work. I am very sorry for the delay.

Update: I am sorry for the delay with adding this feature. We initially had plans to finish this improvement and start working on additional features, but the funding source on our end delayed the project that would have funded this development. I just noticed that this Bounty was fully funded. I will reach out to the original developer and ask him to complete this work. I am very sorry for the delay.

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Apr 21, 2016

Member

And who is the "original developer"? We have a lot of changes, especially regarding our federation implementation, going on, so it would really make sense to have direct conversations...

Member

denschub commented Apr 21, 2016

And who is the "original developer"? We have a lot of changes, especially regarding our federation implementation, going on, so it would really make sense to have direct conversations...

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Apr 21, 2016

Ankush Kataria. He wrote the specification and user stories. Since this feature uses federation, I agree that we should review the software specification, user stories, and step definitions. Thank you for triggering this review.

Ankush Kataria. He wrote the specification and user stories. Since this feature uses federation, I agree that we should review the software specification, user stories, and step definitions. Thank you for triggering this review.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 1, 2016

I am having some trouble getting in contact with Ankush. We are in the process of hiring another Rails software engineer. If Ankush is not able to finish the work, this new engineer should be able to continue the work. Very sorry for the delay.

nicholas-itpedia commented May 1, 2016

I am having some trouble getting in contact with Ankush. We are in the process of hiring another Rails software engineer. If Ankush is not able to finish the work, this new engineer should be able to continue the work. Very sorry for the delay.

@MightyCreak

This comment has been minimized.

Show comment
Hide comment
@MightyCreak

MightyCreak May 1, 2016

I hope his work isn't lost 😒
To me, this feature is, by far, the most anticipated one.
I'm sorry I can't help you more than that, just wanted to show you some support ;)

I hope his work isn't lost 😒
To me, this feature is, by far, the most anticipated one.
I'm sorry I can't help you more than that, just wanted to show you some support ;)

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 2, 2016

Thank you for your support!

ITpedia Solutions is a professional software engineering company. We have backups of the software specification, scenarios, step definitions, etc.

Thank you for your support!

ITpedia Solutions is a professional software engineering company. We have backups of the software specification, scenarios, step definitions, etc.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 2, 2016

I received a communication from Ankush and unfortunately he is too busy and not able to continue to work on this project at this time. We are in the process of hiring another Rails software engineer. As soon as he is trained and and available, I will have him finish this task.

@denschub we will review federation

I received a communication from Ankush and unfortunately he is too busy and not able to continue to work on this project at this time. We are in the process of hiring another Rails software engineer. As soon as he is trained and and available, I will have him finish this task.

@denschub we will review federation

@davidlatapie

This comment has been minimized.

Show comment
Hide comment
@davidlatapie

davidlatapie May 21, 2016

I can't believe after FIVE years, this is still not fixed. And copy and paste is limited when you enriched text with markdown.

I can't believe after FIVE years, this is still not fixed. And copy and paste is limited when you enriched text with markdown.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 24, 2016

This definitly needs to be fixed.

ghost commented May 24, 2016

This definitly needs to be fixed.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 26, 2016

UPDATE

Ankush is now able to work on this task! This is probably the best outcome since he is familiar with the project. I hope he will be able to start this week after we review the software specification and the most recent federation changes.

[nods to @denschub]

Hey look I edited this!

nicholas-itpedia commented May 26, 2016

UPDATE

Ankush is now able to work on this task! This is probably the best outcome since he is familiar with the project. I hope he will be able to start this week after we review the software specification and the most recent federation changes.

[nods to @denschub]

Hey look I edited this!

@davidlatapie

This comment has been minimized.

Show comment
Hide comment
@davidlatapie

davidlatapie May 26, 2016

Can't wait to have some material to promote Diaspora more!

Can't wait to have some material to promote Diaspora more!

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub May 26, 2016

Member

@nicholas-itpedia I guess, it would be best if he hops into IRC to have a chat about the implementations or something.

Member

denschub commented May 26, 2016

@nicholas-itpedia I guess, it would be best if he hops into IRC to have a chat about the implementations or something.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 31, 2016

@denschub I am available on Google Hangouts

nicholas-itpedia commented May 31, 2016

@denschub I am available on Google Hangouts

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia May 31, 2016

UPDATE

Ankush should be able to restart this project in ~ 10 - 12 days. This will also give us time to speak to @denschub

UPDATE

Ankush should be able to restart this project in ~ 10 - 12 days. This will also give us time to speak to @denschub

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Jun 6, 2016

@denschub please message me directly with information on how I can contact you on Google Hangouts, Skype, or other communication service.

@denschub please message me directly with information on how I can contact you on Google Hangouts, Skype, or other communication service.

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Jun 6, 2016

Member

@davidlatapie I cannot remember someone asking you for your contact details. This is a GitHub issue, not a chatting board. Please refrain from further posting anything not related to this issue, there are other communication channels for that kind of stuff, thanks.

@nicholas-itpedia I will not join a Hangout with you - I do not use Google services. ;) Shoot me an email to mail@dennis-schubert.de.

Member

denschub commented Jun 6, 2016

@davidlatapie I cannot remember someone asking you for your contact details. This is a GitHub issue, not a chatting board. Please refrain from further posting anything not related to this issue, there are other communication channels for that kind of stuff, thanks.

@nicholas-itpedia I will not join a Hangout with you - I do not use Google services. ;) Shoot me an email to mail@dennis-schubert.de.

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Jun 6, 2016

Member

Actually, no. Don't send me an email. Get Ankush involved with this issue. @SuperTux88 will probably answer all questions regarding the federation implementation and I can answer everything else. There is nothing we need to chat about in private. ;)

Member

denschub commented Jun 6, 2016

Actually, no. Don't send me an email. Get Ankush involved with this issue. @SuperTux88 will probably answer all questions regarding the federation implementation and I can answer everything else. There is nothing we need to chat about in private. ;)

@davidlatapie

This comment has been minimized.

Show comment
Hide comment
@davidlatapie

davidlatapie Jun 6, 2016

Sorry, I did not see @denschub in the post. I will remove these informations.

davidlatapie commented Jun 6, 2016

Sorry, I did not see @denschub in the post. I will remove these informations.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Jun 11, 2016

UPDATE

Unfortunately Ankush has informed me that he is unable to complete this task. The good news is that ITpedia Solutions LLC will be hiring a full time software engineer who has Rails knowledge and experience. He is very smart and is already exceeding our expectations. Like any Rail developer, he is looking forward to working on some Rails projects (he currently works on our Python / Javascript related Odoo projects). He will have to focus on some overdue customer projects first, but I anticipate him being able to work on this project soon and hopefully within the next 3 months. I apologize for the continued delay.

@SuperTux88 we will contact you to review Diaspora federation. We recognize this is critical to this project.

UPDATE

Unfortunately Ankush has informed me that he is unable to complete this task. The good news is that ITpedia Solutions LLC will be hiring a full time software engineer who has Rails knowledge and experience. He is very smart and is already exceeding our expectations. Like any Rail developer, he is looking forward to working on some Rails projects (he currently works on our Python / Javascript related Odoo projects). He will have to focus on some overdue customer projects first, but I anticipate him being able to work on this project soon and hopefully within the next 3 months. I apologize for the continued delay.

@SuperTux88 we will contact you to review Diaspora federation. We recognize this is critical to this project.

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Jun 11, 2016

Member

Once again. Do not contact anyone over a channel that's not our IRC channels or this issue. Questions regarding the implementation of this issue should be asked here. We're an open source project and we decided that this is where we have our technical discussions.

Also, please note that I will no longer block this issue for you anymore. If anyone else is interested in implementing it, feel free.

Member

denschub commented Jun 11, 2016

Once again. Do not contact anyone over a channel that's not our IRC channels or this issue. Questions regarding the implementation of this issue should be asked here. We're an open source project and we decided that this is where we have our technical discussions.

Also, please note that I will no longer block this issue for you anymore. If anyone else is interested in implementing it, feel free.

@nicholas-itpedia

This comment has been minimized.

Show comment
Hide comment
@nicholas-itpedia

nicholas-itpedia Jun 11, 2016

@denschub I am confused. I have not yet contacted anyone outside of using Github. We are new to Diaspora development, and I have not used IRC is quite some time. If we need to use IRC or this issue to communicate about the implementation of this issue, I never refused to use it.

Thank you for "unblocking" this issue. I did not remember that it was blocked. If anyone else wants to help with this issue, please do so. Our end goal is the same. Give Diaspora users the ability to edit posts and close this issue!

@denschub I am confused. I have not yet contacted anyone outside of using Github. We are new to Diaspora development, and I have not used IRC is quite some time. If we need to use IRC or this issue to communicate about the implementation of this issue, I never refused to use it.

Thank you for "unblocking" this issue. I did not remember that it was blocked. If anyone else wants to help with this issue, please do so. Our end goal is the same. Give Diaspora users the ability to edit posts and close this issue!

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Jun 11, 2016

Member

I have not yet contacted anyone outside of using Github

You tend to offer various alternate communication channels. ;)

Member

denschub commented Jun 11, 2016

I have not yet contacted anyone outside of using Github

You tend to offer various alternate communication channels. ;)

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Jun 11, 2016

Member

Thank you for "unblocking" this issue. I did not remember that it was blocked.

I've told someone that they should not start working on this since I assumed you were actively working on that back at the time. No worries, though, happens from time to time...

Member

denschub commented Jun 11, 2016

Thank you for "unblocking" this issue. I did not remember that it was blocked.

I've told someone that they should not start working on this since I assumed you were actively working on that back at the time. No worries, though, happens from time to time...

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Nov 6, 2016

Member

hopefully within the next 3 months

;-)

Member

denschub commented Nov 6, 2016

hopefully within the next 3 months

;-)

@trebmuh

This comment has been minimized.

Show comment
Hide comment
@trebmuh

trebmuh Feb 1, 2017

adding my voice for the issue here

trebmuh commented Feb 1, 2017

adding my voice for the issue here

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 6, 2017

Sounds like a good idea

ghost commented Apr 6, 2017

Sounds like a good idea

@8spinach

This comment has been minimized.

Show comment
Hide comment
@8spinach

8spinach Apr 6, 2017

8spinach commented Apr 6, 2017

@denschub

This comment has been minimized.

Show comment
Hide comment
@denschub

denschub Apr 6, 2017

Member

Maybe not use this issue for "I want it to"-comments

Member

denschub commented Apr 6, 2017

Maybe not use this issue for "I want it to"-comments

@8spinach

This comment has been minimized.

Show comment
Hide comment
@8spinach

8spinach Apr 6, 2017

8spinach commented Apr 6, 2017

@Flaburgan

This comment has been minimized.

Show comment
Hide comment
@Flaburgan

Flaburgan Apr 6, 2017

Member

Well, we all want it, what we are missing is resources, not willing. So do it, or find a dev to do it, or put some money on bountysource to pay a dev to do it... That's the blocking point. :)

Member

Flaburgan commented Apr 6, 2017

Well, we all want it, what we are missing is resources, not willing. So do it, or find a dev to do it, or put some money on bountysource to pay a dev to do it... That's the blocking point. :)

@8spinach

This comment has been minimized.

Show comment
Hide comment
@8spinach

8spinach Apr 6, 2017

8spinach commented Apr 6, 2017

@goobertron

This comment has been minimized.

Show comment
Hide comment
@goobertron

goobertron Apr 7, 2017

this whole thread has been about funded companies hiring devs to do the work and then, for months, nothing, repeatedly.

Well, not quite. The first time a company entered the fray as far as I'm aware was ITPedia in May 2015, and that company repeatedly said it was working on it, then wasn't, then was, then wasn't.

The rest of it has been a mixture of people trying to work out how to implement such a feature and people saying 'I want to be able to edit my posts!'

Without the developer from ITPedia telling us what work they have completed, there is no way of knowing, because they don't seem to have worked in a very open way. I think we can assume that nothing useful to this project has been completed.

If someone wants to start developing this and believes they have the skills to tackle at least one part of the implementation (because this is bound to be a large and complex task), I'm sure they will get a lot of support from core devs. If people want this feature, they can contribute to the bounty on it to encourage skilled developers to take it on.

this whole thread has been about funded companies hiring devs to do the work and then, for months, nothing, repeatedly.

Well, not quite. The first time a company entered the fray as far as I'm aware was ITPedia in May 2015, and that company repeatedly said it was working on it, then wasn't, then was, then wasn't.

The rest of it has been a mixture of people trying to work out how to implement such a feature and people saying 'I want to be able to edit my posts!'

Without the developer from ITPedia telling us what work they have completed, there is no way of knowing, because they don't seem to have worked in a very open way. I think we can assume that nothing useful to this project has been completed.

If someone wants to start developing this and believes they have the skills to tackle at least one part of the implementation (because this is bound to be a large and complex task), I'm sure they will get a lot of support from core devs. If people want this feature, they can contribute to the bounty on it to encourage skilled developers to take it on.

@frnco

This comment has been minimized.

Show comment
Hide comment
@frnco

frnco Jun 21, 2017

Versioning seems plausible, as limited time editing.

The issue seems to be fixing a typo versus meaningful changes.

As both freedom and privacy are core values for Diaspora, it gets harder to decide, especially if they pull in different directions.

My suggestion would be to not have versioning (Freedom and Privacy, you control your data), but notify any person who commented when a post is edited, allowing the commenter to see what changed from the version he commented on and the current version. Everyone is in control.

Con is the risk of having a bazillion edit notifications...

frnco commented Jun 21, 2017

Versioning seems plausible, as limited time editing.

The issue seems to be fixing a typo versus meaningful changes.

As both freedom and privacy are core values for Diaspora, it gets harder to decide, especially if they pull in different directions.

My suggestion would be to not have versioning (Freedom and Privacy, you control your data), but notify any person who commented when a post is edited, allowing the commenter to see what changed from the version he commented on and the current version. Everyone is in control.

Con is the risk of having a bazillion edit notifications...

@grahamperrin

This comment has been minimized.

Show comment
Hide comment
@grahamperrin

grahamperrin Jun 28, 2017

… bazillion edit notifications

Instead:

  1. have just one
  2. if that one notification is read and if reading of the first notification is followed by another edition of the post, then another notification …

… bazillion edit notifications

Instead:

  1. have just one
  2. if that one notification is read and if reading of the first notification is followed by another edition of the post, then another notification …
@SuperTux88

This comment has been minimized.

Show comment
Hide comment
@SuperTux88

SuperTux88 Jan 23, 2018

Member

I created a pull request for adding edit functionality to the diaspora protocol here: diaspora/diaspora_federation#94

This doesn't add this functionality to diaspora yet, but it is needed to make it possible to add it to diaspora in the future. So feedback related to the protocol part of this feature is welcome there.

Member

SuperTux88 commented Jan 23, 2018

I created a pull request for adding edit functionality to the diaspora protocol here: diaspora/diaspora_federation#94

This doesn't add this functionality to diaspora yet, but it is needed to make it possible to add it to diaspora in the future. So feedback related to the protocol part of this feature is welcome there.

@SuperTux88 SuperTux88 referenced this issue in diaspora/diaspora_federation Jan 23, 2018

Merged

Editable entities #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment