Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reshares in single post-view #4056

Merged
merged 2 commits into from Mar 13, 2013
Merged

fix reshares in single post-view #4056

merged 2 commits into from Mar 13, 2013

Conversation

fabianrbz
Copy link
Contributor

Fix for #4023

The behaviour of the reshares after this pull request is the following:

  • A user can reshare a post from the stream and from the single post view (even if it was reshared by somebody else).
  • In the stream, if you try to reshare a post that you already reshared you get the following flash message: "That good, huh? You've already reshared that post!"
  • If you open in one tab a post and reshare that post in the stream. If you try to reshare that post in the tab that shows the single post-view -without hitting refresh- you get the flash message: "That good, huh? You've already reshared that post!"
    And it works the other way around.

A review is welcome!

@jhass
Copy link
Member

jhass commented Mar 12, 2013

Looks good to me :)

@fabianrbz
Copy link
Contributor Author

Changelog updated!

@Raven24
Copy link
Member

Raven24 commented Mar 13, 2013

thank you very much!

Raven24 added a commit that referenced this pull request Mar 13, 2013
fix reshares in single post-view
@Raven24 Raven24 merged commit ecd93bc into diaspora:develop Mar 13, 2013
@jhass
Copy link
Member

jhass commented Mar 13, 2013

Great, thanks! Could you ammend the changelog update to the original commit in the future? This way we won't get that many meaningless "update changelog" commits in the history :)

@fabianrbz
Copy link
Contributor Author

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants