Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop, replace and update vendored assets #5194

Open
jhass opened this issue Sep 1, 2014 · 0 comments
Open

Drop, replace and update vendored assets #5194

jhass opened this issue Sep 1, 2014 · 0 comments
Labels
♻️ code refactor newcomer 🎨 ui

Comments

@jhass
Copy link
Member

jhass commented Sep 1, 2014 •
edited
Loading

Partial contributions to this issue are welcome.

The following directories contain third-party assets (CSS, Javascript):

  • vendor/assets/javascripts
  • app/assets/stylesheets/vendor

The following tasks should be performed on these files:

  1. Are they still in use? If not drop them
  2. Are they packaged in a gem or bower package? If yes replace them. See https://rubygems.org and https://rails-assets.org
  3. Are there newer upstream versions? If yes update them.
  4. Do they contain modifications when compared to the upstream versions? If yes move them to lib/assets
  5. Are they under app/assets but are unmodified upstream code? If yes move them to vendor/assets

If the assets aren't packaged as gem or bower package, doing so is another consideration.

Finally files in app/assets/javascripts should be evaluated for their library character. If they seem like libraries they should be moved to lib/assets/javascripts.
@jhass jhass added ui labels Sep 1, 2014
@strivedi183 strivedi183 mentioned this issue Sep 30, 2014
Merged
jhass added a commit that referenced this issue Oct 1, 2014
@jhass
Merge pull request #5263 from strivedi183/5194-replace_punycodejs_ven…
0e1bac5 
…dored_asset_with_bower_package

Replaced punycode.js vendored asset with a bower package #5194
@strivedi183 strivedi183 mentioned this issue Oct 6, 2014
Merged
jhass added a commit that referenced this issue Oct 7, 2014
@jhass
Merge pull request #5297 from strivedi183/5194-replace_jquerytextchan…
803c257 
…gejs_vendored_asset_with_bower_package

Replaced jquery.textchange.js vendored asset with a bower package #5194
@strivedi183 strivedi183 mentioned this issue Oct 7, 2014
Merged
jhass added a commit that referenced this issue Oct 7, 2014
@jhass
Merge pull request #5299 from strivedi183/5194-replace_jqueryplacehol…
518186a 
…derjs_vendored_asset_with_bower_package

Replaced jquery.placeholder.js vendored asset with bower package and updated to latest version #5194
@strivedi183 strivedi183 mentioned this issue Oct 8, 2014
Merged
@strivedi183 strivedi183 mentioned this issue Oct 23, 2014
Merged
jhass added a commit that referenced this issue Oct 23, 2014
@jhass
Merge pull request #5368 from strivedi183/5194-replace-jqueryhotkysjs…
62f1015 
…-vendored-asset-with-bower-package

Replaced jquery.hotkeys.js vendored asset with a bower package #5194
strivedi183 added a commit to strivedi183/diaspora that referenced this issue May 29, 2015
@strivedi183
Replaces facebox vendored asset with rails gem diaspora#5194
47c2e4c
strivedi183 added a commit to strivedi183/diaspora that referenced this issue May 29, 2015
@strivedi183
Replaces facebox vendored asset with rails gem diaspora#5194
108c35b
@strivedi183 strivedi183 mentioned this issue May 29, 2015
Closed
jhass pushed a commit that referenced this issue May 29, 2015
@strivedi183 @jhass
Replaces facebox vendored asset with rails gem #5194
b026a2a 
closes #6005
@svbergerem svbergerem mentioned this issue Aug 5, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♻️ code refactor newcomer 🎨 ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhass