You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When changing user settings the users controller renders the edit page which leads to a wrong url (pod.tld/user) and a settings nav with no selected active page. Before #5580 it redirected to the user edit page which is not possible anymore because it would break the validation errors added in #5580.
The text was updated successfully, but these errors were encountered:
First I tried to change the PUT/PATCH route from /user to /user/edit so it matched the proper page URL on UsersController#update action.
But that didn't help with the styling of the navbar! As it turned out, the current_page? method used in the navbar templatereturns false on every request that is not GET or HEAD. Replacing the calls with a simple own current_path? method fixed the thing. There are still some issues from #6801 left which are probably caused by the same thing, but otherwise it works as expected.
Tell me please, if the approach is generally fine and I will prepare a PR then.
I don't know if it's the same issue but a similar problem exists on the sign up page. If you submit the form with some errors (for example, email already token, or the two passwords don't match) then the page will reload with a broken design.
When changing user settings the users controller renders the edit page which leads to a wrong url (pod.tld/user) and a settings nav with no selected active page. Before #5580 it redirected to the user edit page which is not possible anymore because it would break the validation errors added in #5580.
The text was updated successfully, but these errors were encountered: