Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data "Download my profile" button active even when profile not requested. Trying to download raises S3 error. #6197

Open
jaywink opened this issue Jul 14, 2015 · 2 comments
Labels

Comments

@jaywink
Copy link
Contributor

jaywink commented Jul 14, 2015

I'm logging this bug into the core software since it is possible it affects any pod running with uploads on S3 - though of course it is possible this is a joindiaspora.com only issue.

When visiting settings on joindiaspora.com, the "Download my profile" button is active even though there has not been a request for the profile data. Clicking it brings an error.

From a user report, this error comes even after profile data has successfully(?) been generated. See error report in this post, image attached here.

Maybe either joindiaspora.com configuration issue or bug? @maxwell any chance you could check for the first?

I've requested my profile and waiting for it to be ready to check whether the file is given without access rights errors from S3.

selection_104
selection_106
scaled_full_0b4322ff52023e0e8a8c

@maxwell
Copy link
Member

maxwell commented Jul 14, 2015

Unless you want to make the link publicly accessible, all S3 links have an expiry, set in the carrierwave uploader. I think the default may only be 5 minutes.

Most likely, we want to make that timeframe 24 hours, and tell customers that the link is only valid for 24 hours.

  • maxwell

On Jul 14, 2015, at 11:49 AM, Jason Robinson notifications@github.com wrote:

I'm logging this bug into the core software since it is possible it affects any pod running with uploads on S3 - though of course it is possible this is a joindiaspora.com only issue.

When visiting settings on joindiaspora.com, the "Download my profile" button is active even though there has not been a request for the profile data. Clicking it brings an error.

From a user report, this error comes even after profile data has successfully(?) been generated. See error report in this post, image attached here.

Maybe either joindiaspora.com configuration issue or bug? @maxwell any chance you could check for the first?

I've requested my profile and waiting for it to be ready to check whether the file is given without access rights errors from S3.


Reply to this email directly or view it on GitHub.

@jaywink
Copy link
Contributor Author

jaywink commented Aug 12, 2015

So yeah, a few changes then:

  1. Add configurable carrierwave expiry
  2. Don't show download button in UI after creation+expiry
  3. Warn users in email notification that file will expiry after X time

@jhass jhass added the bounty label Mar 9, 2018
@jhass jhass removed the bounty label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants