Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are not updated when stream is reloaded #6473

Closed
SansPseudoFix opened this issue Oct 9, 2015 · 7 comments
Closed

Notifications are not updated when stream is reloaded #6473

SansPseudoFix opened this issue Oct 9, 2015 · 7 comments

Comments

@SansPseudoFix
Copy link
Contributor

SansPseudoFix commented Oct 9, 2015

With new stream loading, notifications are not shown when I reload.

@jaywink
Copy link
Contributor

jaywink commented Oct 10, 2015

I'd almost call this regression since they used to update when clicking 'Stream'. So functionality has in essence broken ;)

@jaywink
Copy link
Contributor

jaywink commented Oct 11, 2015

I'm tagging this as a bug and regression since it does break old functionality. Previously when you clicked on for example pod name, notifications were loaded. The fact that they don't load now is behaviour change which hasn't been discussed, so imho it is a bug.

Also, "mark all read" in the notifications panel is broken in some cases. To reproduce:

  • mark all notifications as read
  • wait some time until there are new notifications
  • click the notification icon -> notifications are fetched and displayed

expected: mark all read button is active (as there are clearly unread notifications)

what happens: button is disabled

selection_088

Discussed with @svbergerem that if a proper fix cannot be done for the coming minor release, selected links can be changed to have old functionality by removing rel=backbone from them. I'll try to do a fix today to implement a route for the notification counts and poll when needed.

@svbergerem
Copy link
Member

selected links can be changed to have old functionality by removing rel=backbone from them

Which won't implement the feature for the stream selection when you select another stream. (I am not talking about the links in the header)

jaywink added a commit to jaywink/diaspora that referenced this issue Oct 11, 2015
jaywink added a commit to jaywink/diaspora that referenced this issue Oct 11, 2015
jaywink added a commit to jaywink/diaspora that referenced this issue Oct 11, 2015
jaywink added a commit to jaywink/diaspora that referenced this issue Oct 11, 2015
Add notifications count route
Add JS notifications unread polling

Refs: diaspora#6473
@jaywink jaywink mentioned this issue Oct 11, 2015
4 tasks
jaywink added a commit to jaywink/diaspora that referenced this issue Oct 11, 2015
Add notifications count route
Add JS notifications unread polling

Refs: diaspora#6473
@denschub
Copy link
Member

I marked this bug to block the upcoming release which I froze moments ago since I think this will make users angry. I'd be pretty happy to see a fix soon, if possible. :)

denschub added a commit that referenced this issue Oct 20, 2015
Fixes #6494 and #6473
Partly reverts 517cd56
[ci skip]
@denschub
Copy link
Member

Closed via aabe695

@svbergerem
Copy link
Member

This issue still exists for the stream links in the left navbar.

@svbergerem svbergerem reopened this Oct 20, 2015
@svbergerem svbergerem removed this from the 0.5.4.0 milestone Oct 20, 2015
@denschub
Copy link
Member

True, thanks. Related to (and possibly in the future solved by) #6493.

jaywink added a commit to jaywink/diaspora that referenced this issue Nov 21, 2015
Add notifications count route
Add JS notifications unread polling

Refs: diaspora#6473
jaywink added a commit to jaywink/diaspora that referenced this issue Jan 1, 2016
Add notifications count route
Add JS notifications unread polling

Refs: diaspora#6473
jaywink added a commit to jaywink/diaspora that referenced this issue Jan 7, 2016
Add notifications count route
Add JS notifications unread polling

Refs: diaspora#6473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants