Remove Vanna Controller from app and fix up notifications controller, views, scripts, specs

[stwf]

Here is the code I needed to remove the VannaController from D*. I did it from the unread notifications branch because that has some improvements. I didn't realize those commits would also be in here. Git newbie working!

Feel free let me know if there is a better way to do this... Or if I'm causing any problems. All the tests pass and what I could test works......

[sarahmei]

<3 your branch name

[stwf]

In an alternate verse she and I are the best of friends!

[stwf]

Universe ugh

[dnsco]

@sarahmei is there a problem with requiring the ApplicationHelper in application controller? do we have all helpers loaded by default? was that turned off?

[sarahmei]

I thought we had all helpers turned on by default.

[maxwell]

They should be. I think it was in the vanna controller because canna controller was not inherited from application controller.

[danielgrippi]

if you axe that ApplicationHelper line, I'd say we're ready to pull it in, yes?

[stwf]

If I take that out I get undefined local variable or method `set_header_data' for <HomeController - tooooo long>:HomeController.. Which is the function that I moved out of ApplicationController, because a comment told me too, lol... Maybe that should go back in?

[maxwell]

Yeah you want that in application controller, not sure who told you that :p

[stwf]

ok, its all in. Only took 2 commits! first master pull!

[danielgrippi]

running rake on my machine right now. should be pulled in shortly!