Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to turn ActivityStreams::Photo to StatusMessage #4308

Conversation

carolinagc
Copy link
Contributor

@jhass
Copy link
Member

jhass commented Jul 17, 2013

Can you delete the model and anything associated please?

@jhass
Copy link
Member

jhass commented Jul 17, 2013

Okay, so you also need to pass the without_protection option to disable mass assignment protection for the type attribute:

p.update_attributes({text: "#{p.text} ![](#{p.image_url})", type: "StatusMessage"}, without_protection: true)

@DeadSuperHero
Copy link
Member

Travis says that the build is failing, the failing test in particular is a cucumber one pertaining to commenting on a show page, which seems unrelated to this.

That being said, this looks great. Is there anything else that needs to be done here, or would you say it's just about good to merge? :)

@Flaburgan
Copy link
Member

The travis thing is just a random fail. We need to upgrade cucumber..

@jhass
Copy link
Member

jhass commented Jul 31, 2013

Rebased, squashed, added changelog entry and merged! Thank you!

@jhass jhass closed this Jul 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants