Always show public photos #6398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| current_user.photos_from(person, limit: limit, max_time: max_time) | ||
| else | ||
| Photo.where(author_id: person.id, public: true) | ||
| end.order("created_at desc") |
There was a problem hiding this comment.
I'd prefer assignment to a local photos = if ... over chaining on end.
svbergerem
force-pushed
the
always-show-public-photos
branch
from
0294fce
to
e77517c
Compare
| context "without a current user" do | ||
| it "returns all public photos" do | ||
| expect(Photo).to receive(:where).with(author_id: @user.person.id, public: true).and_call_original | ||
| Photo.visible(nil, @user.person, :all, nil) |
There was a problem hiding this comment.
I think it's okay to rely on the default values here too.
svbergerem
force-pushed
the
always-show-public-photos
branch
from
e77517c
to
6b295cb
Compare
|
Merged as 05a6d95 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5973.