Remove id selectors for mobile photo show page #7279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperTux88
approved these changes
Jan 15, 2017
| @@ -60,6 +60,6 @@ body { | |||
| } | |||
| } | |||
| } | |||
| // scss-lint:enable IdSelector, SelectorFormat, NestingDepth, SelectorDepth | |||
| // scss-lint:enable SelectorFormat, NestingDepth, SelectorDepth | |||
There was a problem hiding this comment.
Thanks, I missed that when I added the dark-theme 👍
|
Merged as de78926 Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to some screenshots:
Original theme
before
after
Dark theme
before
after
The only visible change is the removed top margin for the
.photos-div. There is already some other margin and now it should be consistent with how we display posts.