Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap sidebar to rightside of view #7344

Closed
wants to merge 1 commit into from

Conversation

robertdavid010
Copy link

This is simply a swapping of the left sidebar to the right side of the tags view.

The information of the stream in the tags view is most likely of greater priority than the sidebar, and feels more comfortable to the user if this is the case.

@Flaburgan
Copy link
Member

Even if I agree that the posts are probably more important than the list of users, I don't feel like we should move the column, that's how the whole interface is, on the stream page, on the user page, on the private message page... So I would prefer to keep the interface consistent here.

@robertdavid010
Copy link
Author

robertdavid010 commented Feb 26, 2017 via email

@Flaburgan
Copy link
Member

Almost every website out there have the menu on the left. I think the users will be more disturbed than anything. Opinions?

@goobertron
Copy link

goobertron commented Jul 7, 2017

Left seems natural to me. I'm pretty sure there was discussion about this when the format was changed from the original layout with side-bars on both left and right of the stream to the current, responsive design.

@denschub
Copy link
Member

denschub commented Jul 7, 2017

Based on our interface flow, left makes the most sense, yeah. However, for RTL language, we'd have to put it on the right side. But eh... maybe one day if we're easily able to rewrite our frontend... ;)

For now, I agree with @Flaburgan and @goobertron - and I will close this PR. For future reference, drastic UI changes like this one are probably best discussed on Discourse first. :)

@denschub denschub closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants