Upgrade to rails 5.1 #7514
Upgrade to rails 5.1 #7514
Conversation
|
Huge job! 👍 |
|
And my workaround in config/initializers/assets.rb doesn't work on travis (works locally in development mode). I pushed another workaround-commit. When importing If anybody has an idea on how to solve this (in a cleaner way), I'm open for help ... |
|
And the updated Anyway ... I go to bed and try that at some other time. |
|
Oh, and mobile cukes broke with timeouts ... that worked locally. Need to check what's the problem there. Maybe some more caches that are there locally but not on travis? |
|
All migrations are dead, since they need explicit Rails version information now: |
|
The problem with cucumber is weird, for example here ... everything worked, until one cuke failed and every following cuke failed with timeout!? |
|
Pushed some commits. I fixed the migrations to be working with Rails 5.1, making sure that you can run all migrations from an empty database. As for the So I decided to remove it. For initial setup, users have to run migrations, but I'll file a follow-up for merging old migrations so we can reduce the number a bit. Also, as a side effect, travis now tests our migrations across databases, so that's cool. We have to change our documentation for installing, but that's doable. I'll fix any issues with the migrations coming up here (for example, MySQL just failed for some reason) |
SuperTux88
force-pushed
the
rails5
branch
3 times, most recently
from
ecf4d0d
to
49df3e6
Compare
SuperTux88
force-pushed
the
rails5
branch
5 times, most recently
from
082dd33
to
5383126
Compare
There was a problem hiding this comment.
Approval for all of @SuperTux88's commits, he will review mine!
|
I reviewed @denschub commits (thanks for the help ❤️) and approve the (can't approve my own PR) I'll rebase this once again and use |
|
👍 |
* don't use `double` for queries * use `second` instead of `at()`.
* load records to array to check them * test that only 15 people are returned
The change in assets.rb should be enough, but it doesn't work, because sprockets `after_initialize` runs before it and initializes sprockets with unfiltered paths. But the trick with the underscore works, because bootstrap-sass has named the file `_bootstrap.scss`, and rails-assets-bootstrap has `bootstrap.scss`, so with `_bootstrap` it uses the correct bootstrap.
... this breaks the Rails 5 upgrade, and it's actually no longer needed. New installations will have the right size anyway, and even if some older installations miss the migration by not updating for 2 years, it still doesn't matter since there is no risk that we will ever have emojis in our migration filenames.
Although this is contrary to rails best-practises, we cannot provide a schema.rb that works for both MySQL and PostgreSQL, so we have no choice. Our migrations are maintained, so it should always be possible to get back to a "clean" database schema anyway.
we released that in 0.5.0.0 in 2015, we do not support skipping majors anyway, and this is broken in Rails 5, so let's remove this. If people upgrade from before 0.5.0.0, they have to upgrade via 0.6.0.0, but that's written in the documenation.
Otherwise Rails 5 would ignore the migration version and create the tables with bitints as IDs on MySQL.
This PR still depends on 2 unreleased gems for rails 5.1 compatibility.
mobile_fufor now)schema.rbthat works with postgres and mysql on travis (remove it)bootstrap-sassandrails-assets-bootstrap(The workaround with_boostrapworks and is OK for now)ToDos after merging:
db:migrateinstead ofdb:schema:load