Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remind the username in the reset password e-mail #8037

Closed
wants to merge 1 commit into from
Closed

Remind the username in the reset password e-mail #8037

wants to merge 1 commit into from

Conversation

Flaburgan
Copy link
Member

No description provided.

@SuperTux88 SuperTux88 mentioned this pull request Jul 16, 2019
Closed
denschub
denschub requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@denschub denschub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, especially since we sometimes receive questions by confused users who receive notification mails but can't remember their username. :)

Minor comments here.

app/views/devise/mailer/confirmation_instructions.markerb Outdated Show resolved Hide resolved
config/locales/devise/devise.en.yml Outdated Show resolved Hide resolved
@Flaburgan
Copy link
Member Author

I completely forgot about that pull request sorry. Remarks are fixed.

@tclaus
Copy link
Member

tclaus commented Oct 21, 2021

LGFM

SuperTux88
SuperTux88 requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@SuperTux88 SuperTux88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this one thing, it looks good to me. Also please squash your commits when you're done.

app/views/devise/mailer/unlock_instructions.markerb Outdated Show resolved Hide resolved
@Flaburgan
Copy link
Member Author

Fixed and squashed ;)

@SuperTux88 SuperTux88 added this to the 0.7.16.0 milestone Oct 22, 2021
SuperTux88 added a commit that referenced this pull request Oct 25, 2021
@SuperTux88
Change placeholder in translations for #8037
89cd777
@SuperTux88
Copy link
Member

Merged as 5b3f75f

Thanks for the PR @Flaburgan 🍪

@Flaburgan Flaburgan deleted the 8030-username-in-email branch November 2, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denschub denschub denschub requested changes

@SuperTux88 SuperTux88 SuperTux88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Flaburgan @tclaus @SuperTux88 @denschub