Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pending photos which were never posted with cronjob #8041

Closed

Conversation

SuperTux88
Copy link
Member

Only delete photos older than a day, so we don't delete photos for posts which were uploaded 10 minutes ago and the author is still writing the post for it.

@SuperTux88 SuperTux88 added this to the 0.7.13.0 milestone Jul 2, 2019
@denschub
Copy link
Member

denschub commented Jul 2, 2019

@SuperTux88 specs are failing for MySQL 😞

Only delete photos older than a day, so we don't delete photos for posts
which were uploaded 10 minutes ago and the author is still writing the
post for it.
@SuperTux88
Copy link
Member Author

... and travis is finally green (after 3 hours of waiting for all builds to start and finish ...).

It wasn't MySQL, because on this PC I still have a MySQL dev env, but tests were green ... but I'm an idiot and I don't want to talk about it ;)

@denschub
Copy link
Member

denschub commented Jul 2, 2019

Ohhh, that was a good one! My approval is still valid. :)

@SuperTux88 SuperTux88 closed this in df4e79b Jul 3, 2019
@SuperTux88
Copy link
Member Author

Merged as df4e79b

Thanks @denschub for the review 🍪

@SuperTux88 SuperTux88 deleted the cleanup-pending-photos branch July 3, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants