Re-add raw to a photo's json.
#8100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we need it for showing the raw image in the lightbox. This got lost, as the photo extension was made after API development started.
denschub
force-pushed
the
hotfix/fix-raw-photos
branch
from
bcbcee1
to
8a1bc48
Compare
jhass
approved these changes
Feb 4, 2020
This is a temporary workaround. Adding the real raw photo is quite a challange and touches multiple components nobody wants to touch right now. As this change is blocking an actual hotfix, this is fine, and will be properly fixed at a later time.
denschub
force-pushed
the
hotfix/fix-raw-photos
branch
from
8a1bc48
to
6df742a
Compare
|
Should we open an issue as a follow-up to be sure to not forget about that then? @denschub maybe you want to do it as it looks like a good place to explain what you went through when beginning to do it? Thanks for that patch in any case :) |
|
@Flaburgan it's high on my ToDo list - both filing the issue, and fixing it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current issue with lightboxes not working.
To make sure we don't acidentially drop it again, I added
rawas a required field to the schema. Unfortunately, this broke CI, as we did not exposerawfor profile pictures, which do reference the same API schema.Initially, I wanted to expose the actual raw image on the API, and I still plan on doing this, but this change turns out to be a magical journey through all parts of diaspora, and will take me a bit of time. To get the lightboxes fixed in the meantime, this PR exposes the
scaled_fullversion as the "raw" image.