API: Don't return notifications target unless it's a post #8103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
force-pushed
the
feature/api_no_person_target
branch
from
244615b
to
0dbafa1
Compare
jhass
force-pushed
the
feature/api_no_person_target
branch
from
1a7e259
to
e51b803
Compare
denschub
approved these changes
Feb 8, 2020
jhass
force-pushed
the
feature/api_no_person_target
branch
from
e51b803
to
60523c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API docs imply that's how it should be since the "target" can be inferred from
the event creator in the non post notifications case.
Also fixed the
only_unreadparameter to only listen totrue. (Can send that separately if you prefer.)