New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating all ruby dependencies to current versions #8431
Conversation
Even Debian oldstable has Redis 6, so if someone still runs on Redis 5, they should be ashamed of themselves. 😜 |
This breaks compatibility with redis <6
@denschub OK, I was actually wrong about that, I only looked at the requirements of the new Worse is probably, that ubuntu 22.04 also only has redis 6.0 😞 But there are official apt repos for debian/ubuntu from redis: https://redis.io/docs/getting-started/installation/install-redis-on-linux/ So, we either probably still should add something to the changelog, hinting at these repos, or downgrade sidekiq again until there is an LTS Ubuntu with redis 7? |
@SuperTux88 Ah, that's not great. There's nothing that's relevant to us in the Sidekiq 7 changelog, so I'd opt for downgrading for now. |
I would have wanted to use the new capsules to see if they can replace our own workarounds to prevent to not run more than one export/import in parallel, as this looked really nice. I didn't include this here, as I didn't want to mix upgrades with new features, but planned to look into that next. So I would have tended to add a note to the changelog, and then just use the newer redis packages from redis. But I can also understand that some podmins maybe don't want to do that and only want to use packages from their official distro repo? So I guess downgrading is also fine. 🤷♂️ |
Yeah, I've seen that. But not having capsules doesn't hurt us at the moment - it only prevents us from cleaning up a bit of code. I don't see this being a reasonable motivation for forcing podmins from the added hassle (and, in turn, from the bunch of support requests we will inevitably get). Maybe if we (read: me) have figured out That One Deployment Thing for 1.0, we can update Sidekiq again. |
There is one update that requires a special mention: The current sidekiq version requires redis 6+, so I don't know if we should mention that in the changelog?