Allow CORS requests to nodeinfo endpoint #8436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denschub
approved these changes
Oct 16, 2023
|
Merged. We'll release this relatively soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web applications meant to work with different Fediverse applications need to download
/.well-known/nodeinfoand/nodeinfo/2.0in order to determine what software they are dealing with. Diaspora currently doesn’t allow this to happen on the client side, without CORS headers third-party web pages aren’t allowed to do it. I’ve hit this issue myself when implementing “Share to Fediverse” functionality for my website.Adding CORS headers is trivial and solves this issue. With the node info being public information, there is no reason why third-party websites shouldn’t have access to it.