Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cross-reference spreadsheet #14

Closed
ghost opened this issue Jun 14, 2018 · 7 comments
Closed

Create cross-reference spreadsheet #14

ghost opened this issue Jun 14, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jun 14, 2018

The purpose of this is similar to Sanctuary/notes. The idea is to have a spreadsheet containing a list of all the functions and major structs, and the location of them for each game version. This eliminates the need for offsets in the source code, since one can easily find the location of specific code across multiple game versions.

Instead of documenting every single patch, I'd like to focus on the notable ones:

  • 1.09(b) - PSX: This is already finished as per Devilution
  • 1.00 Debug: Very useful as it contains debug code not found in the release build, possibly other kinky features
  • 1.04/Hellfire 1.01: Useful to document the new features (DRLG)
  • Battle.net Beta: Now this is where things get really interesting. This patch was nearly identical to the final game in functionality, but contained lots of removed code. This includes code for unused spells, items, and more! I'd like to add this code back as a comment, since the devs likely kept it as such
  • Alpha Demo: Only useful for spells like Invisibility, Sentinel, and Blood Boil.

The excel spreadsheet will look similar to a map file. It will have multiple offset columns.

@ghost ghost added the enhancement New feature or request label Jun 15, 2018
@ghost
Copy link
Author

ghost commented Jun 18, 2018

Begin drafting a few different layouts. I like the last one but it would take forever to color each function. Any preferences guys?
1337

@Cabalist
Copy link

I like the last one as well.

I can write a python script to get them formatted if the data is there. :)

@ghost
Copy link
Author

ghost commented Jun 19, 2018

@Cabalist That's great! I'll keep you posted once I get the initial spreadsheet uploaded. The text will be formatted as tabbed-text.

@Cabalist
Copy link

Cabalist commented Jun 19, 2018

Fantastic. I'll set it up so that it can be run dynamically.

Excel is no issue but would this be worthwhile as an HTML document as well?

@DaveidWeba
Copy link

@Cabalist I know both Google Sheets and Excel can make an HTML capable file with ease.

Sheets
File > Publish To The Web > Link: Web Page > Publish
Example

Excel
File > Export > Change File Type > Save As > Web Page (.html) or Single File Web Page (.mhtml)

@ghost ghost mentioned this issue Jun 20, 2018
@ghost
Copy link
Author

ghost commented Jun 21, 2018

Initial version has been uploaded. galaxyhaxz/devilution@5f31783

I've decided not to include any PSX references, since the code is much too different. Instead it will focus primarily on Hellfire and the battle.net beta, with the debug build on the side. There's converters online for HTML but the size is pretty big so I'm just uploading the .XLS for now.

@ghost
Copy link
Author

ghost commented Aug 3, 2018

Handled via https://github.com/diasurgical/scalpel

@ghost ghost closed this as completed Aug 3, 2018
AJenbo pushed a commit that referenced this issue Dec 17, 2019
Render menu using release assets
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants