Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte-identical version of appfat_cpp_init. #110

Merged
1 commit merged into from
Jul 1, 2018
Merged

Byte-identical version of appfat_cpp_init. #110

1 commit merged into from
Jul 1, 2018

Conversation

mewmew
Copy link
Contributor

@mewmew mewmew commented Jul 1, 2018

Updates #11.

Note, the same patch can be applied to all _cpp_init functions.

@ghost
Copy link

ghost commented Jul 1, 2018

I wonder if this will also fix the issue some people are having with Critical Sections?

Also, it's nice the delete operator works now. I had no idea what that was!

@sskras
Copy link
Contributor

sskras commented Jul 1, 2018

I am totally RE noob, but this diff drawed my attention.

Is the code in appfat.cpp expected to be converted into OO style (usin C++ classes with member functions, constructor, overloaded operators like delete) anytime in future?

@sunverwerth
Copy link
Contributor

Are these functions named based on the PSX symbol files?
I'm wondering because I would be expecting some name mangling for member functions.

Also why cdecl would members functions not be thiscall?

@ghost
Copy link

ghost commented Jul 1, 2018

These functions don't exist on the PSX version or older PC versions either. They created the constructors in patch 1.05 when they upgraded VC from 4.20 -> 5.x. The names are just temporary.

@AJenbo AJenbo mentioned this pull request Jan 2, 2019
38 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants