Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dungeon generation of the Cathedral #165

Merged
2 commits merged into from Aug 20, 2018
Merged

Fix dungeon generation of the Cathedral #165

2 commits merged into from Aug 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2018

Fixed the dungeon generation bug in the Cathedral that caused wrong palette and unreachable areas. A mere 3 numbers... caused because I didn't update the 2d-array pointers correctly after fixing them 5 months ago. 馃槤

@ghost ghost merged commit 9f5883f into master Aug 20, 2018
@ghost ghost deleted the devilicious branch August 20, 2018 02:34
@sskras
Copy link
Contributor

sskras commented Aug 20, 2018

didn't update the 2d-array pointers correctly after fixing them 5 months ago.

@galaxyhaxz, what do you mean: did the decompiler generated some strange constants like 40 and 1600 or was that you who experimented with these values?

Git history is only two months old:)

@ghost
Copy link
Author

ghost commented Aug 20, 2018

First four months the project was unreleased and still in-the-works. Every line of code and data was still part of one file back then, would have been hard to keep track ;P

The exact issue was that the array dungeon[40][40] was being read incorrectly. The [x][y] where x was being multiplied by 40 due to bad decompilation. I plugged in the values so it read array[x][y] but x was still being multiplied and thus reads way outside the array. The exact same issue is also what broke Catacombs.

@mewmew
Copy link
Contributor

mewmew commented Aug 20, 2018

Great work @galaxyhaxz. Haha, always when reading bad decompiler I get the image of a parent telling their decompiler child to behave better.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants