Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic handling the list of items for sale by Adria is broken. In
particular, the logic of SortWitch requires the list to end with an
item having item type ITYPE_NONE.
From SortWitch:
However, this puts a limit (19) on the maximum number of items being
generated for the witchitem array (of length 20). The problem is that
SpawnWitch may generate 20 items if
iCnt = 17
, as made possible bythe following statement.
Since there are 3 items that are always generated (mana, full mana
and town portal), the total number of items generated by SpawnWitch
may be 20, which exceeds the limit (19), thus causing the logic of
SortWitch to go haywire and results in a buffer overflow.