Clean up CheckPlrSpell #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidcc
reviewed
Sep 26, 2018
Source/player.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| UCHAR addflag = FALSE; |
There was a problem hiding this comment.
Looks like this should be BOOL
There was a problem hiding this comment.
With BOOL (32bit) it ends up as different ASM, i might could make it bool as that is 8bit and should still be exact.
There was a problem hiding this comment.
Even if you fix the other function definitions (bool -> BOOL)?
There was a problem hiding this comment.
Thanks I totally missed that the 2td and 3td where bool and not BOOL. I also found another error where sTownSpell was also not set to BOOL but unsigned char, both are fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.