Clang format based on WebKit style #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this PR should be merged after the PRs currently open. This is done. |
Base default style on WebKit and set a few options specific to Devilution. * `AlignTrailingComments: true` * `AllowShortBlocksOnASingleLine: true` * `AllowShortFunctionsOnASingleLine: None` * `PointerAlignment: Right` For header files, we also want to add * `AlignConsecutiveAssignments: true`
AJenbo
reviewed
Oct 6, 2018
AJenbo
reviewed
Oct 6, 2018
Generated as follows: $ clang-format --version clang-format version 7.0.0 (tags/RELEASE_700/final) $ clang-format -style=webkit -dump-config > .clang-format
* AlignTrailingComments: true * AllowShortBlocksOnASingleLine: true * AllowShortFunctionsOnASingleLine: None * PointerAlignment: Right Note, currently, the format.sh script uses the config file for .cpp files. The `AlignConsecutiveAssignments: true` setting is specifically added for .h files. I could not find a way to specify what config file to use for clang-format. So, for now, the config file is used for .cpp.
The Source/.clang-format config is used for *.cpp files. The root .clang-format config is used for *.h files.
AJenbo
approved these changes
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clang-format script.
Base default style on WebKit and set a few options
specific to Devilution.
AlignTrailingComments: trueAllowShortBlocksOnASingleLine: trueAllowShortFunctionsOnASingleLine: NonePointerAlignment: RightFor header files, we also want to add
AlignConsecutiveAssignments: trueThis allows us to format
enums.hto alignkey = valpairs; e.g.Note: For starters, we only format the files that are already binary exact (or almost binary exact, in the case of
player.cpp). This reduces churn and we can easily extend from here going forward.The list of clang-format style settings is described in https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Fixes #182.