Uncomment delete to make appfat.cpp compile as C. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, in the future, we want to figure out how the delete operator was overloaded and included while still compiling the project as C. Most likely it was overloaded in the Storm header, and being included by appfat.cpp (which is the first file being compiled in alphabetic order), it was included here. Fixes #528.
AJenbo
reviewed
Jan 12, 2019
|
LGTM |
|
Mac builds are failing for previously known good builds and other PR's also, so going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, in the future, we want to figure out how the
delete operator was overloaded and included while
still compiling the project as C.
Most likely it was overloaded in the Storm header,
and being included by appfat.cpp (which is the first
file being compiled in alphabetic order), it was
included here.
Fixes #528.