Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a rare legacy bug causing network desync #1546

Merged
merged 1 commit into from Apr 15, 2021

Conversation

FluffyQuack
Copy link
Contributor

@FluffyQuack FluffyQuack commented Apr 15, 2021

If a player tries to swap sword+shield with a two-handed weapon without sufficient inventory space it leads to a network desync (what's in the right hand gets de-equipped on other clients, but not for local client).

Video example: https://www.youtube.com/watch?v=2GtUv-m8FoI

The cause was the game always sending a network packet for de-equipping the right-hand item before even checking if the local player has space to do the weapon swap.

(Uh, never mind the shield position looking weird. That's an unrelated issue caused by another commit.)

… sword+shield with a two-handed weapon without sufficient inventory space.
@AJenbo
Copy link
Member

AJenbo commented Apr 15, 2021

Nice find

@AJenbo AJenbo merged commit 051ac24 into diasurgical:master Apr 15, 2021
@julealgon julealgon added the vanilla Bugs found also in the original Diablo 1.09b release label Apr 16, 2021
@julealgon
Copy link
Contributor

May I ask why you are using a cow emoji on all your changes? Can we not do that? The emojis are there to help understanding what a commit does, not for any other reason.

@AJenbo
Copy link
Member

AJenbo commented Apr 16, 2021

My guess is that it's there to remind us to have fun while working on the project and not be too serious about it, this is probably especially true for people who aren't necessarily here to hone their skills as professional developers. Only a few of us use the emojis at all. I personally do not find the cow a distraction.

@FluffyQuack FluffyQuack deleted the PR-TwoHandedWeaponSwapDesync branch June 5, 2021 14:26
@FluffyQuack FluffyQuack restored the PR-TwoHandedWeaponSwapDesync branch June 5, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vanilla Bugs found also in the original Diablo 1.09b release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants