fix queuing operating object when clicking during attack #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qndel
added
fix
qndel
changed the title
julealgon
reviewed
Apr 27, 2021
| @@ -3504,8 +3504,6 @@ void CheckNewPath(int pnum) | |||
| if (object[i]._oBreak == 1) { | |||
| d = GetDirection(plr[pnum].position.current.x, plr[pnum].position.current.y, object[i]._ox, object[i]._oy); | |||
| StartAttack(pnum, d); | |||
| } else { | |||
There was a problem hiding this comment.
What happens if we just remove the entire ACTION_OPERATE block? Seems like it only exists for melee attacks (for some weird reason) even though you can be on melee while casting or while firing a bow.
There was a problem hiding this comment.
well I guess it wouldn't allow you to break barrels fast
There was a problem hiding this comment.
Oh is breaking barrels an operate instead of an attack?! Interesting! So that's why this was here?
There was a problem hiding this comment.
well, it performs a check for breaking and barrels are the only breakable object in the game iirc : P
- we can always remove more code in future PRs, this code was the minimal amount required to fix the bug :D
julealgon
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple object interactions after an attack if you click while attacking
