switch-next: Build with CMake

[glebm]

I haven't tested the binary

[rsn8887]

The binary works, but the embedded title, author name, and version seem to be wrong: Title is Devilution Team (used to be "diablo-nx"), Author is "Unspecified Author" (should be "Devilution Team", and version is "0.5.0" (no clue what it should be).

The executable name is "DevilutionX.nro" instead of "diablo-nx.nro", but that might be intended?

[rsn8887]

Binary works, but APP_AUTHOR and APP_TITLE are wrong

[rsn8887]

The error display requester also works, it shows a red "Date file error" window if the .MPG file is missing. I suppose it should be "data file", not "date file".

Also, on Switch, I cannot press OK in that requeter, it seems maybe the SDL_controller button input is not hooked up so I have no way to cause an OK in these new error requesters.

Notice for other UI elements, we hooked up the controller input, e.g. here:

devilutionX/SourceX/DiabloUI/diabloui.cpp

Line 192 in 5963dc8

if (event->type == SDL_CONTROLLERBUTTONDOWN) {

EDIT: It doesn't really matter for this particular requester, because a restart is required to fix the problem anyways.

[glebm]

Thank you for testing!

The error display requester also works, it shows a red "Date file error" window if the .MPG file is missing. I suppose it should be "data file", not "date file".

This typo is fixed on master but the switch-next branch hasn't been rebased yet.

Also, on Switch, I cannot press OK in that requeter, it seems maybe the SDL_controller button input is not hooked up so I have no way to cause an OK in these new error requesters.

Thanks, we should fix this directly on master.

[glebm]

Binary works, but APP_AUTHOR and APP_TITLE are wrong

This is fixed now. The version etc are consistent with the non-switch build (they weren't before).

[rsn8887]

I think this PR should be ready to merge then AFAIK.

[rsn8887]

Although what happened to the line endings in switch/switch_keyboard.cpp? Is it intended? The diff shows the file completely changed, although there's only one tiny change. I think that's line endings then.

[glebm]

Although what happened to the line endings in switch/switch_keyboard.cpp? Is it intended? The diff shows the file completely changed, although there's only one tiny change. I think that's line endings then...

Yeah, the line endings were wrong previously. It's not a big issue, as GitHub has a hide whitespace diff option.

[rsn8887]

Ok then this is ready to merge as far as I am concerned. Awesome work.

[AJenbo]

Thanks for testing, I'll rebase and replace the old PR