-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 3XDAMVDEM Logic for Arrows #3864
Conversation
The Deadly Hunter bow contains the 3XDAMVDEM affix power which isn't present in missiles.cpp, preventing the affix from doing anything altogether. This fix adds the logic from player.cpp in a consistent way with how damage gets handled in melee combat.
Co-authored-by: Anders Jenbo <anders@jenbo.dk>
…vilutionX into deadly-hunter-fix
This is clearly a bug, but if this bow was doing three times the total char damage it will be far too powerful, totally breaking the balance in the game. I propose another fix, to simply remove the IPL_3XDAMVDEM affix from its properties and assume that the bug is not implementing the damage, but removing the affix from the item once they decided that the extra damage should not be implemented. |
The scope of DevilutionX isn't to change the balance of the game, but to fix bugs and improve the game engine |
So let's assume the bug is forgetting to remove the affix. |
Afaik this will cause all missiles shot by the player 3x, it should be limited to only arrows.
The |
The Deadly Hunter bow contains the 3XDAMVDEM affix power which isn't present in missiles.cpp, preventing the affix from doing anything altogether. This fix adds the logic from player.cpp in a consistent way with how damage gets handled in melee combat.