Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3XDAMVDEM Logic for Arrows #3864

Merged
merged 7 commits into from
May 31, 2022

Conversation

kphoenix137
Copy link
Collaborator

The Deadly Hunter bow contains the 3XDAMVDEM affix power which isn't present in missiles.cpp, preventing the affix from doing anything altogether. This fix adds the logic from player.cpp in a consistent way with how damage gets handled in melee combat.

The Deadly Hunter bow contains the 3XDAMVDEM affix power which isn't present in missiles.cpp, preventing the affix from doing anything altogether. This fix adds the logic from player.cpp in a consistent way with how damage gets handled in melee combat.
Source/missiles.cpp Outdated Show resolved Hide resolved
@kphoenix137 kphoenix137 changed the title Implemented 3XDAMVDEM Logic for Missiles Implemented 3XDAMVDEM Logic for Arrows Dec 30, 2021
@kphoenix137 kphoenix137 changed the title Implemented 3XDAMVDEM Logic for Arrows Implement 3XDAMVDEM Logic for Arrows Dec 30, 2021
@ikonomov
Copy link
Contributor

This is clearly a bug, but if this bow was doing three times the total char damage it will be far too powerful, totally breaking the balance in the game. I propose another fix, to simply remove the IPL_3XDAMVDEM affix from its properties and assume that the bug is not implementing the damage, but removing the affix from the item once they decided that the extra damage should not be implemented.

@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Jan 27, 2022

This is clearly a bug, but if this bow was doing three times the total char damage it will be far too powerful, totally breaking the balance in the game. I propose another fix, to simply remove the IPL_3XDAMVDEM affix from its properties and assume that the bug is not implementing the damage, but removing the affix from the item once they decided that the extra damage should not be implemented.

The scope of DevilutionX isn't to change the balance of the game, but to fix bugs and improve the game engine

@ikonomov
Copy link
Contributor

ikonomov commented Jan 27, 2022

So let's assume the bug is forgetting to remove the affix.

@diasurgical diasurgical locked as too heated and limited conversation to collaborators Jan 27, 2022
@diasurgical diasurgical deleted a comment from ikonomov Jan 27, 2022
@AJenbo AJenbo added this to the 1.5.0 milestone Apr 3, 2022
AJenbo
AJenbo previously approved these changes May 31, 2022
@AJenbo AJenbo dismissed their stale review May 31, 2022 05:20

Afaik this will cause all missiles shot by the player 3x, it should be limited to only arrows.

@StephenCWills
Copy link
Member

Afaik this will cause all missiles shot by the player 3x, it should be limited to only arrows.

The MissilesData[t].mType == 0 condition should only apply to arrows so that should already be handled.

@AJenbo AJenbo merged commit 0692c75 into diasurgical:master May 31, 2022
@kphoenix137 kphoenix137 deleted the deadly-hunter-fix branch February 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants