Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal spell levels #7112

Merged
merged 10 commits into from
May 10, 2024
Merged

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented May 7, 2024

Fixes: #7111

When loading/unpacking player data, spells with a book level of -1 are set to spell level 0, and if the game mode isn't Hellfire, Apocalypse and Nova get set to spell level 0. Additionally, all indices of _pSplLvl[64] which do not have a SpellID enumerator are automatically loaded/unpacked as spell level 0.

@kphoenix137
Copy link
Collaborator Author

Not sure why this completely destroys the time demo

@AJenbo
Copy link
Member

AJenbo commented May 9, 2024

Could you try and run them locally to see what failed about them?

@AJenbo AJenbo marked this pull request as draft May 9, 2024 22:53
@kphoenix137 kphoenix137 marked this pull request as ready for review May 10, 2024 00:21
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice with the added comments

@AJenbo AJenbo merged commit 557fd2a into diasurgical:master May 10, 2024
22 checks passed
@kphoenix137 kphoenix137 deleted the fix-saved-slvls branch May 10, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue Report]: Hellfire spells stay dormant if you switch to Classic.
2 participants