Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor sourmash/lca/command_summarize.py to clean up if statements #1182

Closed
ctb opened this issue Aug 24, 2020 · 1 comment · Fixed by #1540
Closed

refactor sourmash/lca/command_summarize.py to clean up if statements #1182

ctb opened this issue Aug 24, 2020 · 1 comment · Fixed by #1540
Labels
good first issue

Comments

@ctb
Copy link
Contributor

ctb commented Aug 24, 2020

in #1175 we turned off merged-signature summarization in favor of singletons. however, I noticed that there were a lot of if filename statements that are no longer needed.

this is not a public API so we can change it pretty easily. it's a small cleanup.
@ctb
Copy link
Contributor Author

ctb commented Aug 24, 2020

(it is also well covered by tests, I think, which makes life much easier!)

@marisalim marisalim mentioned this issue May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] refactor lca_summarize to remove unnecessary if statements sourmash-bio/sourmash
1 participant
@ctb